Patchwork [U-Boot,v2] Standalone Apps: Standalone apps should need only exports.h.

login
register
mail settings
Submitter Mike Partington
Date Oct. 27, 2010, 8:31 p.m.
Message ID <1288211469-32443-1-git-send-email-mparting@lexmark.com>
Download mbox | patch
Permalink /patch/71947/
State Accepted
Delegated to: Wolfgang Denk
Headers show

Comments

Mike Partington - Oct. 27, 2010, 8:31 p.m.
Modify exports.h to remove its dependencies on other files, thus
enabling standalone apps to require only exports.h from the U-Boot
source tree.  This appears to be the intent based on the following
note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html

Signed-off-by: Mike Partington <mparting@lexmark.com>
---
Changes for v2:
   - Replace domain specific email address with generic address

 examples/standalone/atmel_df_pow2.c |    1 +
 examples/standalone/stubs.c         |    1 +
 include/exports.h                   |    5 +----
 3 files changed, 3 insertions(+), 4 deletions(-)
Wolfgang Denk - Dec. 6, 2011, 7:53 p.m.
Dear Mike Partington,

In message <1288211469-32443-1-git-send-email-mparting@lexmark.com> you wrote:
> Modify exports.h to remove its dependencies on other files, thus
> enabling standalone apps to require only exports.h from the U-Boot
> source tree.  This appears to be the intent based on the following
> note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html
> 
> Signed-off-by: Mike Partington <mparting@lexmark.com>
> ---
> Changes for v2:
>    - Replace domain specific email address with generic address
> 
>  examples/standalone/atmel_df_pow2.c |    1 +
>  examples/standalone/stubs.c         |    1 +
>  include/exports.h                   |    5 +----
>  3 files changed, 3 insertions(+), 4 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
Kumar Gala - Dec. 7, 2011, 3:38 a.m.
On Dec 6, 2011, at 1:53 PM, Wolfgang Denk wrote:

> Dear Mike Partington,
> 
> In message <1288211469-32443-1-git-send-email-mparting@lexmark.com> you wrote:
>> Modify exports.h to remove its dependencies on other files, thus
>> enabling standalone apps to require only exports.h from the U-Boot
>> source tree.  This appears to be the intent based on the following
>> note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html
>> 
>> Signed-off-by: Mike Partington <mparting@lexmark.com>
>> ---
>> Changes for v2:
>>   - Replace domain specific email address with generic address
>> 
>> examples/standalone/atmel_df_pow2.c |    1 +
>> examples/standalone/stubs.c         |    1 +
>> include/exports.h                   |    5 +----
>> 3 files changed, 3 insertions(+), 4 deletions(-)
> 
> Applied, thanks.
> 
> Best regards,
> 
> Wolfgang Denk

This breaks builds:

In file included from qsort.c:19:0:
/local/home/galak/git/u-boot/include/exports.h:19:27: error: expected declaration specifiers or '...' before 'va_list'
qsort.c: In function 'qsort':
qsort.c:30:3: warning: implicit declaration of function 'assert'

Simon has posted a patch that fixes:

http://patchwork.ozlabs.org/patch/129855/

- k

Patch

diff --git a/examples/standalone/atmel_df_pow2.c b/examples/standalone/atmel_df_pow2.c
index b5b4503..2e14aba 100644
--- a/examples/standalone/atmel_df_pow2.c
+++ b/examples/standalone/atmel_df_pow2.c
@@ -8,6 +8,7 @@ 
 
 #include <common.h>
 #include <exports.h>
+#include <spi.h>
 
 #define CMD_ID    0x9f
 #define CMD_STAT  0xd7
diff --git a/examples/standalone/stubs.c b/examples/standalone/stubs.c
index 2d2e709..1ebe43b 100644
--- a/examples/standalone/stubs.c
+++ b/examples/standalone/stubs.c
@@ -1,3 +1,4 @@ 
+#include <common.h>
 #include <exports.h>
 
 #ifndef GCC_VERSION
diff --git a/include/exports.h b/include/exports.h
index 7404a7c..01b83dc 100644
--- a/include/exports.h
+++ b/include/exports.h
@@ -3,8 +3,6 @@ 
 
 #ifndef __ASSEMBLY__
 
-#include <common.h>
-
 /* These are declarations of exported functions available in C code */
 unsigned long get_version(void);
 int  getc(void);
@@ -12,7 +10,7 @@  int  tstc(void);
 void putc(const char);
 void puts(const char*);
 int printf(const char* fmt, ...);
-void install_hdlr(int, interrupt_handler_t*, void*);
+void install_hdlr(int, void (*interrupt_handler_t)(void *), void*);
 void free_hdlr(int);
 void *malloc(size_t);
 void free(void*);
@@ -30,7 +28,6 @@  int ustrtoul(const char *cp, char **endp, unsigned int base);
 int i2c_write (uchar, uint, int , uchar* , int);
 int i2c_read (uchar, uint, int , uchar* , int);
 #endif
-#include <spi.h>
 
 void app_startup(char * const *);