Patchwork [U-Boot] cmd_date: constify

login
register
mail settings
Submitter Mike Frysinger
Date Oct. 20, 2010, 11:17 a.m.
Message ID <1287573443-6578-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/71902/
State Accepted
Delegated to: Wolfgang Denk
Headers show

Comments

Mike Frysinger - Oct. 20, 2010, 11:17 a.m.
Many strings in this file need not be writable.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 common/cmd_date.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Wolfgang Denk - Nov. 28, 2010, 9:02 p.m.
Dear Mike Frysinger,

In message <1287573443-6578-1-git-send-email-vapier@gentoo.org> you wrote:
> Many strings in this file need not be writable.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  common/cmd_date.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)

Applied to "next" branch, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/common/cmd_date.c b/common/cmd_date.c
index 50b4240..88c8d85 100644
--- a/common/cmd_date.c
+++ b/common/cmd_date.c
@@ -31,7 +31,7 @@ 
 
 DECLARE_GLOBAL_DATA_PTR;
 
-const char *weekdays[] = {
+static const char * const weekdays[] = {
 	"Sun", "Mon", "Tues", "Wednes", "Thurs", "Fri", "Satur",
 };
 
@@ -41,7 +41,7 @@  const char *weekdays[] = {
 #define RELOC(a)	((typeof(a))((unsigned long)(a) + gd->reloc_off))
 #endif
 
-int mk_date (char *, struct rtc_time *);
+int mk_date (const char *, struct rtc_time *);
 
 int do_date (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
@@ -106,7 +106,7 @@  int do_date (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 /*
  * simple conversion of two-digit string with error checking
  */
-static int cnvrt2 (char *str, int *valp)
+static int cnvrt2 (const char *str, int *valp)
 {
 	int val;
 
@@ -131,7 +131,7 @@  static int cnvrt2 (char *str, int *valp)
  * Some basic checking for valid values is done, but this will not catch
  * all possible error conditions.
  */
-int mk_date (char *datestr, struct rtc_time *tmp)
+int mk_date (const char *datestr, struct rtc_time *tmp)
 {
 	int len, val;
 	char *ptr;