Patchwork [U-Boot] command_t: punt unused type

login
register
mail settings
Submitter Mike Frysinger
Date Oct. 20, 2010, 7:35 a.m.
Message ID <1287560109-31612-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/71890/
State Accepted
Commit 40b484a3dfb586076c6cfba44eff3e3cf0b5bd1f
Delegated to: Wolfgang Denk
Headers show

Comments

Mike Frysinger - Oct. 20, 2010, 7:35 a.m.
The recent command clean up to constify the argv option to command funcs
missed the command_t type itself.  This is probably because there are no
build time warnings from it because no one is actually using this thing.
So just punt it rather than fix it.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 include/command.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Wolfgang Denk - Nov. 28, 2010, 9:01 p.m.
Dear Mike Frysinger,

In message <1287560109-31612-1-git-send-email-vapier@gentoo.org> you wrote:
> The recent command clean up to constify the argv option to command funcs
> missed the command_t type itself.  This is probably because there are no
> build time warnings from it because no one is actually using this thing.
> So just punt it rather than fix it.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  include/command.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)

Applied to "next" branch, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/include/command.h b/include/command.h
index 5c14616..a153ce9 100644
--- a/include/command.h
+++ b/include/command.h
@@ -86,8 +86,6 @@  extern int cmd_auto_complete(const char *const prompt, char *buf, int *np, int *
  * void function (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]);
  */
 
-typedef	void	command_t (cmd_tbl_t *, int, int, char *[]);
-
 #if defined(CONFIG_CMD_MEMORY)		\
     || defined(CONFIG_CMD_I2C)		\
     || defined(CONFIG_CMD_ITEST)	\