diff mbox

[U-Boot,09/11] Drop the static inline print_cpuinfo()

Message ID 20170123203127.19240-10-sjg@chromium.org
State Accepted
Commit cc664000c2b8a6e33a67e2ff06dfa8d97e6c5f79
Delegated to: Tom Rini
Headers show

Commit Message

Simon Glass Jan. 23, 2017, 8:31 p.m. UTC 
This is only called from one place and the function cannot be inlined.
Convert it to a normal function.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 common/board_f.c | 2 ++
 include/common.h | 7 -------
 2 files changed, 2 insertions(+), 7 deletions(-)

Comments

Tom Rini Jan. 26, 2017, 3 a.m. UTC | #1 
On Mon, Jan 23, 2017 at 01:31:25PM -0700, Simon Glass wrote:

> This is only called from one place and the function cannot be inlined.
> Convert it to a normal function.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/common/board_f.c b/common/board_f.c
index 8c9453cb7e..e5d112dd1e 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -916,7 +916,9 @@  static init_fnc_t init_sequence_f[] = {
 #if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SH)
 	checkcpu,
 #endif
+#if defined(CONFIG_DISPLAY_CPUINFO)
 	print_cpuinfo,		/* display cpu info (and speed) */
+#endif
 #if defined(CONFIG_MPC5xxx)
 	prt_mpc5xxx_clks,
 #endif /* CONFIG_MPC5xxx */
diff --git a/include/common.h b/include/common.h
index 53cdadf09c..35ac78fede 100644
--- a/include/common.h
+++ b/include/common.h
@@ -284,14 +284,7 @@  int mac_read_from_eeprom(void);
 extern u8 __dtb_dt_begin[];	/* embedded device tree blob */
 int set_cpu_clk_info(void);
 int mdm_init(void);
-#if defined(CONFIG_DISPLAY_CPUINFO)
 int print_cpuinfo(void);
-#else
-static inline int print_cpuinfo(void)
-{
-	return 0;
-}
-#endif
 int update_flash_size(int flash_size);
 int arch_early_init_r(void);