From patchwork Tue Oct 19 05:03:38 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nobuhiro Iwamatsu X-Patchwork-Id: 71872 Return-Path: X-Original-To: wd@gemini.denx.de Delivered-To: wd@gemini.denx.de Received: from diddl.denx.de (diddl.denx.de [10.0.0.6]) by gemini.denx.de (Postfix) with ESMTP id C0762136320 for ; Tue, 19 Oct 2010 07:03:15 +0200 (CEST) Received: from diddl.denx.de (localhost.localdomain [127.0.0.1]) by diddl.denx.de (Postfix) with ESMTP id A06DE348C9D1 for ; Tue, 19 Oct 2010 07:03:15 +0200 (CEST) Received: from pop.mnet-online.de by diddl.denx.de with POP3 (fetchmail-6.3.17) for (single-drop); Tue, 19 Oct 2010 07:03:15 +0200 (CEST) Received: from murder ([192.168.8.180]) by backend2 (Cyrus v2.2.12) with LMTPA; Tue, 19 Oct 2010 07:00:25 +0200 X-Sieve: CMU Sieve 2.2 Received: from mail.m-online.net (localhost [127.0.0.1]) by frontend1.mail.m-online.net (Cyrus v2.2.12) with LMTPA; Tue, 19 Oct 2010 07:00:24 +0200 Received: from scanner-3.m-online.net (unknown [192.168.6.168]) by mail.m-online.net (Postfix) with ESMTP id B78D31C001ED; Tue, 19 Oct 2010 07:00:24 +0200 (CEST) Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by mxin-3.m-online.net (Postfix) with ESMTP id 0D87246C0A4; Tue, 19 Oct 2010 07:00:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id BB54C2809C; Tue, 19 Oct 2010 07:00:18 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3LEUEbJaHgB0; Tue, 19 Oct 2010 07:00:18 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 416B328098; Tue, 19 Oct 2010 07:00:11 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2C07C28093 for ; Tue, 19 Oct 2010 07:00:06 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N4gDTJvEsN0z for ; Tue, 19 Oct 2010 07:00:04 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-px0-f172.google.com (mail-px0-f172.google.com [209.85.212.172]) by theia.denx.de (Postfix) with ESMTP id 0720C2807E for ; Tue, 19 Oct 2010 07:00:01 +0200 (CEST) Received: by pxi9 with SMTP id 9so99219pxi.3 for ; Mon, 18 Oct 2010 22:00:00 -0700 (PDT) Received: by 10.142.72.16 with SMTP id u16mr4205886wfa.389.1287464400522; Mon, 18 Oct 2010 22:00:00 -0700 (PDT) Received: from chimagu (49.14.32.202.bf.2iij.net [202.32.14.49]) by mx.google.com with ESMTPS id y42sm18245923wfd.22.2010.10.18.21.59.58 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 18 Oct 2010 21:59:59 -0700 (PDT) Received: from iwamatsu by chimagu with local (Exim 4.72) (envelope-from ) id 1P84MX-0003Cv-Hf; Tue, 19 Oct 2010 14:03:49 +0900 From: Nobuhiro Iwamatsu To: u-boot@lists.denx.de Date: Tue, 19 Oct 2010 14:03:38 +0900 Message-Id: <1287464627-12302-1-git-send-email-iwamatsu@nigauri.org> X-Mailer: git-send-email 1.7.1 Cc: biggerbadderben@gmail.com Subject: [U-Boot] [PATCH 01/10 v2] net: rtl8169: Add initialized eth_device structure X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Virus-Scanned: by amavisd-new at m-online.net rtl8169 does not have write_hwaddr function. However, eth stuff executes write_hwaddr function because eth_device structure has not been initialized. Signed-off-by: Nobuhiro Iwamatsu CC: Ben Warren --- drivers/net/rtl8169.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index e45d1a5..d6bc514 100644 --- a/drivers/net/rtl8169.c +++ b/drivers/net/rtl8169.c @@ -894,7 +894,12 @@ int rtl8169_initialize(bd_t *bis) debug ("rtl8169: REALTEK RTL8169 @0x%x\n", iobase); dev = (struct eth_device *)malloc(sizeof *dev); - + if (!dev) { + printf("Can not allocate memory of rtl8169\n"); + break; + } + + memset(dev, 0, sizeof(*dev)); sprintf (dev->name, "RTL8169#%d", card_number); dev->priv = (void *) devno;