diff mbox

python-lxml: allow build as host package

Message ID 1485179476-6049-1-git-send-email-casantos@datacom.ind.br
State Superseded, archived
Headers show

Commit Message

Carlos Santos Jan. 23, 2017, 1:51 p.m. UTC 
While currently there is no in-tree Buildroot package which depends on
host-python-lxml, we (DATACOM) have some proprietary modules that use it
in their test scripts.

We tested python-lxml as host package and confirmed that it builds and
works correctly. Someone else might require it, so we are proposing its
inclusion.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>

---
Additional background (DATACOM-specific): so far we circumvent the lack
of host-python-lxml invoking python with an absolute path in the tests
(/usr/bin/python) but this forces us to install python-lxml on all build
hosts and developer workstations.

Change-Id: If51b034e9579e938a4e7470a58689d7eb34a6a3f
Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
---
 package/python-lxml/python-lxml.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Petazzoni Jan. 23, 2017, 10:34 p.m. UTC | #1 
Hello,

On Mon, 23 Jan 2017 11:51:16 -0200, Carlos Santos wrote:
> While currently there is no in-tree Buildroot package which depends on
> host-python-lxml, we (DATACOM) have some proprietary modules that use it
> in their test scripts.
> 
> We tested python-lxml as host package and confirmed that it builds and
> works correctly. Someone else might require it, so we are proposing its
> inclusion.
> 
> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>

I remain a little bit uncomfortable with host packages that have no
in-tree user, as it means the code is dead and never tested by our
autobuilder infrastructure.

That being said, lots of aspects of Buildroot are already not tested by
our autobuilder infra, so maybe my argument is not so good after all.

Peter, what is your feeling on this ?

Thomas
diff mbox

Patch

diff --git a/package/python-lxml/python-lxml.mk b/package/python-lxml/python-lxml.mk
index 62c2980..22287b9 100644
--- a/package/python-lxml/python-lxml.mk
+++ b/package/python-lxml/python-lxml.mk
@@ -27,5 +27,9 @@  PYTHON_LXML_DEPENDENCIES = libxml2 libxslt zlib
 PYTHON_LXML_BUILD_OPTS = \
 	--with-xslt-config=$(STAGING_DIR)/usr/bin/xslt-config \
 	--with-xml2-config=$(STAGING_DIR)/usr/bin/xml2-config
+HOST_PYTHON_LXML_BUILD_OPTS = \
+	--with-xslt-config=$(HOST_DIR)/usr/bin/xslt-config \
+	--with-xml2-config=$(HOST_DIR)/usr/bin/xml2-config
 
 $(eval $(python-package))
+$(eval $(host-python-package))