Patchwork [U-Boot] Kirkwood: Changes specific to ARM relocation support

login
register
mail settings
Submitter Prafulla Wadaskar
Date Sept. 30, 2010, 5:54 p.m.
Message ID <1285869240-17251-3-git-send-email-prafulla@marvell.com>
Download mbox | patch
Permalink /patch/71854/
State Changes Requested
Headers show

Comments

Prafulla Wadaskar - Sept. 30, 2010, 5:54 p.m.
All Kirkwood based boards are supported for this new implementation
ref: dovs/README.arm-relocation

Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
---
 include/configs/mv-common.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Prafulla Wadaskar - Oct. 1, 2010, 7:21 a.m.
> -----Original Message-----
> From: Heiko Schocher [mailto:hs@denx.de] 
> Sent: Thursday, September 30, 2010 9:11 PM
> To: Prafulla Wadaskar
> Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
> Subject: Re: [U-Boot] [PATCH] Kirkwood: Changes specific to 
> ARM relocation support
> 
> Hello Prafulla,
> 
> Prafulla Wadaskar wrote:
> > All Kirkwood based boards are supported for this new implementation
> > ref: dovs/README.arm-relocation
> 
> should be docs/README.arm-relocation
> 
> > Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> > ---
> >  include/configs/mv-common.h |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/configs/mv-common.h 
> b/include/configs/mv-common.h
> > index ca9f33b..b80ad00 100644
> > --- a/include/configs/mv-common.h
> > +++ b/include/configs/mv-common.h
> > @@ -56,6 +56,12 @@
> >  #error "Unsupported SoC"
> >  #endif
> >  
> > +/* additions for new ARM relocation support */
> > +#undef CONFIG_RELOC_FIXUP_WORKS
> 
> Should not be necessary.

Will remove it

> 
> > +#define CONFIG_SYS_SDRAM_BASE		0x00000000
> > +#define CONFIG_SYS_INIT_SP_ADDR		(0x00000000 + 0x1000 - \
> > +					CONFIG_SYS_GBL_DATA_SIZE)
> 
> I setup the initial stack in the SDRAM, because I didn;t know,
> if there is on this cpu family a better place for the initial stack.
> (Some cpu internal ram?)
> 
> Do you know, if we have something like this on this cpu family?

Yes, Kirkwood do have internal SRAM of 2kB size called Security SRAM
I have never used it before, I will give a try to use it. Otherwise using a data cache will be other option

Regards..
Prafulla . .

Patch

diff --git a/include/configs/mv-common.h b/include/configs/mv-common.h
index ca9f33b..b80ad00 100644
--- a/include/configs/mv-common.h
+++ b/include/configs/mv-common.h
@@ -56,6 +56,12 @@ 
 #error "Unsupported SoC"
 #endif
 
+/* additions for new ARM relocation support */
+#undef CONFIG_RELOC_FIXUP_WORKS
+#define CONFIG_SYS_SDRAM_BASE		0x00000000
+#define CONFIG_SYS_INIT_SP_ADDR		(0x00000000 + 0x1000 - \
+					CONFIG_SYS_GBL_DATA_SIZE)
+
 /*
  * CLKs configurations
  */