diff mbox

[wwwdocs,coding,conventions] Mention OVERRIDE/FINAL

Message ID alpine.LSU.2.20.1701221003420.3033@anthias.pfeifer.com
State New
Headers show

Commit Message

Gerald Pfeifer Jan. 22, 2017, 9:05 a.m. UTC 
Hi David,

On Fri, 14 Oct 2016, David Malcolm wrote:
> I propose that we update our coding conventions to mention the OVERRIDE
> and FINAL macros in the paragraph that discusses virtual funcs.
> 
> The attached patch (to the website) does so.
> 
> OK to commit?

I saw that Pedro agreed, but none of our global reviewers (such as
Bernd) chimed in.

So, while this looks fine from a pure wwwdocs perspective, I did
not feel comfortable approving it without larger concensus.  If
you want to push this, perhaps send a note/request to gcc@ proposing
this?

Gerald
diff mbox

Patch

Index: htdocs/codingconventions.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v
retrieving revision 1.77
diff -u -p -r1.77 codingconventions.html
--- htdocs/codingconventions.html	18 Sep 2016 13:55:17 -0000	1.77
+++ htdocs/codingconventions.html	14 Oct 2016 21:22:44 -0000
@@ -902,7 +902,10 @@  Its use with data-carrying classes is mo
 <p>
 Think carefully about the size and performance impact
 of virtual functions and virtual bases
-before using them.
+before using them.  If you do use virtual functions, use the
+<code>OVERRIDE</code> and <code>FINAL</code> macros from
+<code>include/ansidecl.h</code> to annotate the code for a human reader,
+and to allow sufficiently modern C++ compilers to detect mistakes.
 </p>
 
 <p>