| Message ID | 20170121200708.81625-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Bin Meng |
| Headers | show |
On Sat, Jan 21, 2017 at 10:07 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > This option useful not only for development, but for the platforms where > U-Boot is run from custom ROM bootloader. For example, Intel Edison is > that board. > > Make this option visible that platforms can select it if needed. > --- a/arch/x86/cpu/start.S > +++ b/arch/x86/cpu/start.S > @@ -22,9 +22,8 @@ > * Define this to boot U-Boot from a 32-bit program which sets the GDT > * differently. This can be used to boot directly from any stage of coreboot, > * for example, bypassing the normal payload-loading feature. > - * This is only useful for development. > */ > -#undef LOAD_FROM_32_BIT > +#define LOAD_FROM_32_BIT CONFIG_X86_LOAD_FROM_32_BIT Oops, given one more thought, it should be a bit more verbose I will fix this later. Any other comments I need to address?
Hi Andy, On Sun, Jan 22, 2017 at 4:07 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > This option useful not only for development, but for the platforms where > U-Boot is run from custom ROM bootloader. For example, Intel Edison is > that board. > > Make this option visible that platforms can select it if needed. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > arch/x86/Kconfig | 4 ++++ > arch/x86/cpu/start.S | 3 +-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 0884af22a7..d75ad61d99 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -89,6 +89,10 @@ config X86_RESET_VECTOR > bool > default n > > +config X86_LOAD_FROM_32_BIT > + bool Can we add some help text (ie: the comment block below for the LOAD_FROM_32_BIT in start.S) to this option so that it is visible in "make menuconfig"? > + default n > + > config RESET_SEG_START > hex > depends on X86_RESET_VECTOR > diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S > index a5cba1cf2a..eb4ade6f8c 100644 > --- a/arch/x86/cpu/start.S > +++ b/arch/x86/cpu/start.S > @@ -22,9 +22,8 @@ > * Define this to boot U-Boot from a 32-bit program which sets the GDT > * differently. This can be used to boot directly from any stage of coreboot, > * for example, bypassing the normal payload-loading feature. > - * This is only useful for development. > */ > -#undef LOAD_FROM_32_BIT > +#define LOAD_FROM_32_BIT CONFIG_X86_LOAD_FROM_32_BIT Instead of #defining LOAD_FROM_32_BIT, can we directly use CONFIG_X86_LOAD_FROM_32_BIT in this file? Regards, Bin
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 0884af22a7..d75ad61d99 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -89,6 +89,10 @@ config X86_RESET_VECTOR bool default n +config X86_LOAD_FROM_32_BIT + bool + default n + config RESET_SEG_START hex depends on X86_RESET_VECTOR diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S index a5cba1cf2a..eb4ade6f8c 100644 --- a/arch/x86/cpu/start.S +++ b/arch/x86/cpu/start.S @@ -22,9 +22,8 @@ * Define this to boot U-Boot from a 32-bit program which sets the GDT * differently. This can be used to boot directly from any stage of coreboot, * for example, bypassing the normal payload-loading feature. - * This is only useful for development. */ -#undef LOAD_FROM_32_BIT +#define LOAD_FROM_32_BIT CONFIG_X86_LOAD_FROM_32_BIT .section .text .code32
This option useful not only for development, but for the platforms where U-Boot is run from custom ROM bootloader. For example, Intel Edison is that board. Make this option visible that platforms can select it if needed. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- arch/x86/Kconfig | 4 ++++ arch/x86/cpu/start.S | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-)