Patchwork [U-Boot] USB-CDC: add missing variable in ether.c

login
register
mail settings
Submitter Stefano Babic
Date Aug. 11, 2010, 9:40 p.m.
Message ID <1281562838-6511-1-git-send-email-sbabic@denx.de>
Download mbox | patch
Permalink /patch/71808/
State Superseded
Headers show

Comments

Stefano Babic - Aug. 11, 2010, 9:40 p.m.
qmult was not defined if OTG dualspeed is set.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 drivers/usb/gadget/ether.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Sergei Shtylyov - Aug. 12, 2010, 4:54 p.m.
Hello.

Stefano Babic wrote:

> qmult was not defined if OTG dualspeed is set.

> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>  drivers/usb/gadget/ether.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

> diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
> index e0ebf75..313f15f 100644
> --- a/drivers/usb/gadget/ether.c
> +++ b/drivers/usb/gadget/ether.c
> @@ -144,6 +144,8 @@ static inline int is_cdc(struct eth_dev *dev)
>  #ifdef CONFIG_USB_GADGET_DUALSPEED
>  #define	DEVSPEED	USB_SPEED_HIGH
>  
> +static unsigned qmult = 5;
> +
>  /* for dual-speed hardware, use deeper queues at highspeed */
>  #define qlen(gadget) \
>  	(DEFAULT_QLEN*((gadget->speed == USB_SPEED_HIGH) ? qmult : 1))

    Patch posted by Vitaly looks more complete:

http://lists.denx.de/pipermail/u-boot/2010-August/075412.html

WBR, Sergei

Patch

diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
index e0ebf75..313f15f 100644
--- a/drivers/usb/gadget/ether.c
+++ b/drivers/usb/gadget/ether.c
@@ -144,6 +144,8 @@  static inline int is_cdc(struct eth_dev *dev)
 #ifdef CONFIG_USB_GADGET_DUALSPEED
 #define	DEVSPEED	USB_SPEED_HIGH
 
+static unsigned qmult = 5;
+
 /* for dual-speed hardware, use deeper queues at highspeed */
 #define qlen(gadget) \
 	(DEFAULT_QLEN*((gadget->speed == USB_SPEED_HIGH) ? qmult : 1))