diff mbox

[1/1] mtd: spi-nor: Added support for gd25q16

Message ID 1484940351-8145-1-git-send-email-kdasu.kdev@gmail.com
State Accepted
Commit e9cf64dec1067e6f791ec035e916b30907a87365
Headers show

Commit Message

Kamal Dasu Jan. 20, 2017, 7:25 p.m. UTC
Add GigaDevice GD25Q16 (16M-bit) to supported list.

Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
---
 drivers/mtd/spi-nor/spi-nor.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Marek Vasut Jan. 21, 2017, 11:36 a.m. UTC | #1
On 01/20/2017 08:25 PM, Kamal Dasu wrote:
> Add GigaDevice GD25Q16 (16M-bit) to supported list.
> 
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>

Acked-by: Marek Vasut <marek.vasut@gmail.com>

> ---
>  drivers/mtd/spi-nor/spi-nor.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index da7cd69..8530d51 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -833,6 +833,11 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
>  
>  	/* GigaDevice */
>  	{
> +		"gd25q16", INFO(0xc84015, 0, 64 * 1024,  32,
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +	},
> +	{
>  		"gd25q32", INFO(0xc84016, 0, 64 * 1024,  64,
>  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>  			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>
Cyrille Pitchen Jan. 23, 2017, 10:29 a.m. UTC | #2
Le 21/01/2017 à 12:36, Marek Vasut a écrit :
> On 01/20/2017 08:25 PM, Kamal Dasu wrote:
>> Add GigaDevice GD25Q16 (16M-bit) to supported list.
>>
>> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> 
> Acked-by: Marek Vasut <marek.vasut@gmail.com>
>

Applied to git://github.com/spi-nor/linux.git

Please note that in the subject line, I've replaced "Added support ..." by
"Add support ...". Indeed, looking at submitting-patches.rst:

Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.

This is a very small detail so I thought there would be no need to send
another version for that.

Thanks!

>> ---
>>  drivers/mtd/spi-nor/spi-nor.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index da7cd69..8530d51 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -833,6 +833,11 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
>>  
>>  	/* GigaDevice */
>>  	{
>> +		"gd25q16", INFO(0xc84015, 0, 64 * 1024,  32,
>> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>> +			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>> +	},
>> +	{
>>  		"gd25q32", INFO(0xc84016, 0, 64 * 1024,  64,
>>  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>>  			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>>
> 
> 

Applied to
diff mbox

Patch

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index da7cd69..8530d51 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -833,6 +833,11 @@  static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
 
 	/* GigaDevice */
 	{
+		"gd25q16", INFO(0xc84015, 0, 64 * 1024,  32,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
+	{
 		"gd25q32", INFO(0xc84016, 0, 64 * 1024,  64,
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)