From patchwork Fri Jan 20 18:25:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 717872 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v4q0f4y14z9sCX for ; Sat, 21 Jan 2017 05:26:26 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbdATS0K (ORCPT ); Fri, 20 Jan 2017 13:26:10 -0500 Received: from mout.web.de ([212.227.15.4]:57843 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752782AbdATS0H (ORCPT ); Fri, 20 Jan 2017 13:26:07 -0500 Received: from [192.168.1.2] ([77.182.231.71]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MgfXb-1crNIJ1juR-00NzhY; Fri, 20 Jan 2017 19:25:56 +0100 Subject: [PATCH 07/11] KVM: PPC: Book3S HV: Improve size determinations in five functions To: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Alexander Graf , Benjamin Herrenschmidt , Michael Ellerman , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <83004740-a092-4460-f211-607c5c711e82@users.sourceforge.net> Date: Fri, 20 Jan 2017 19:25:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K0:zM8WHa1mCzqtE2fNnbm3VMmOgAntCABC4yqZYRsIrQTmIRJ7D+E GnfifLv2cStOa0IsCmn+Nkwi/hPOoiu/cf2bzEwEPmBZAgIW0VvD7df5VybF7Ba73v4Yho2 soLt4Me8+qXjxkZR9UPqBIHRwXmVaMkHBLpnMMCRtsDyltMTL/CkKejvi4xL50zblPJYfKO VQXqHOPq6nVntff4DFh1Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:eO4m6qFSDzk=:rX3dXsal5bQ3G6/g3Uz7D0 kpWLztgG0fsrmYiSCz6DAlVIyVimi76q/LyuwDedPW8QQ38bPFY+Ur2sBvVDTNbeCpAhFlhRE oYZDZYHyBXKhtcHm8E1qiGC2g+2dgRwiLpeMEZFO+4PjsLD0eVWCWUdlvME+xw+3VgOzkb9ZK 1zCMkOtpdf1AqM/VuGoxdWEt0ftnxFfR3XdTCKkS1UZxu8CcMAaeFoJZRY4cClKDeTmqEwxpf o2JfondGRvnXNOXGiCE9McwRpqlzojc7VM9/3K3al7QP8RuJNBbqgx1+xZGCqIiVpufLtTssQ eNfHA8bQLwXaDOFigQYiofPgRVFakPokqmovaT1TDFLSu8VlNbEpO7x19dF2fHMZk4dCFjk9Y aIbuaUZiyM8upfp8R3zwxK+OeYpDYrltNK5R+fZJTqX+RjpyB980Ab//GZSXbUN/Pp9HiQGTJ qu/bXfLjq6/zinFJU9jBHnK4ZvgZqxkWq2hfuQyLImJ9lapXVc08hkIYObHuyAJC2lv0iIMjK Qbbi84GiUtxlt3I7MpbMK+0lYmc3u7zGFpUk/AD2em8ykvr74Z7hYSywTc5T4BNOXI+17JiOq wAdDYdiBjfcuqiFN7NN39+4WvahrYtxmOULcwBZ63fRR1acvc/NYQHwuE6D5a+5P0jds72aDQ cuU+hI8S/J3g8NMpUhoBNjB1yi3KMgvIVHmOVTCHMLXaE3N9a1fWYu1NXKfIckoec45Uas1t2 ZGKUl37wOgIWOcoTWyFLGKj4BnUyA7zsKeyMMAyfD+BTHEVuAS2K2M9PzxTFvaCBDYVQ4E2WU av7lE1M Sender: kvm-ppc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm-ppc@vger.kernel.org From: Markus Elfring Date: Fri, 20 Jan 2017 16:23:30 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/powerpc/kvm/book3s_hv.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c index 596201b3f22e..9b7a5a8c9e4b 100644 --- a/arch/powerpc/kvm/book3s_hv.c +++ b/arch/powerpc/kvm/book3s_hv.c @@ -655,7 +655,7 @@ static void kvmppc_create_dtl_entry(struct kvm_vcpu *vcpu, spin_unlock_irq(&vcpu->arch.tbacct_lock); if (!dt || !vpa) return; - memset(dt, 0, sizeof(struct dtl_entry)); + memset(dt, 0, sizeof(*dt)); dt->dispatch_reason = 7; dt->processor_id = cpu_to_be16(vc->pcpu + vcpu->arch.ptid); dt->timebase = cpu_to_be64(now + vc->tb_offset); @@ -1073,7 +1073,7 @@ static int kvm_arch_vcpu_ioctl_get_sregs_hv(struct kvm_vcpu *vcpu, { int i; - memset(sregs, 0, sizeof(struct kvm_sregs)); + memset(sregs, 0, sizeof(*sregs)); sregs->pvr = vcpu->arch.pvr; for (i = 0; i < vcpu->arch.slb_max; i++) { sregs->u.s.ppc64.slb[i].slbe = vcpu->arch.slb[i].orige; @@ -1590,7 +1590,7 @@ static struct kvmppc_vcore *kvmppc_vcore_create(struct kvm *kvm, int core) { struct kvmppc_vcore *vcore; - vcore = kzalloc(sizeof(struct kvmppc_vcore), GFP_KERNEL); + vcore = kzalloc(sizeof(*vcore), GFP_KERNEL); if (!vcore) return NULL; @@ -3204,7 +3204,7 @@ void kvmppc_alloc_host_rm_ops(void) if (kvmppc_host_rm_ops_hv) return; - ops = kzalloc(sizeof(struct kvmppc_host_rm_ops), GFP_KERNEL); + ops = kzalloc(sizeof(*ops), GFP_KERNEL); if (!ops) return; @@ -3713,13 +3713,13 @@ static int kvm_init_subcore_bitmap(void) continue; sibling_subcore_state = - kmalloc_node(sizeof(struct sibling_subcore_state), - GFP_KERNEL, node); + kmalloc_node(sizeof(*sibling_subcore_state), GFP_KERNEL, + node); if (!sibling_subcore_state) return -ENOMEM; memset(sibling_subcore_state, 0, - sizeof(struct sibling_subcore_state)); + sizeof(*sibling_subcore_state)); for (j = 0; j < threads_per_core; j++) { int cpu = first_cpu + j;