From patchwork Thu Apr 15 15:16:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [U-Boot,RFC] possible typo in atmel_lcdfb.c Date: Thu, 15 Apr 2010 05:16:25 -0000 From: Alexander Stein X-Patchwork-Id: 71762 Message-Id: <1271344585-23124-1-git-send-email-alexander.stein@systec-electronic.com> To: u-boot@lists.denx.de This may be a typo inside the driver, but HFP is subtracted by 2 instead of 1 like the other variables in the register. This is stated in AT91SAM9263 Summary 6249H–ATARM–27-Jul-09 p. 940 HFP: Horizontal Front Porch in LCDTIM2 So the driver should also subtract 2 to achieve the correct and exptected behavior. Of cource, in this case all sources which use already this variable must be adjusted to reflect this. Kind regards, Alexander --- drivers/video/atmel_lcdfb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c index c02ffd8..b2b7b8c 100644 --- a/drivers/video/atmel_lcdfb.c +++ b/drivers/video/atmel_lcdfb.c @@ -121,7 +121,7 @@ void lcd_ctrl_init(void *lcdbase) lcdc_writel(panel_info.mmio, ATMEL_LCDC_TIM1, value); /* Horizontal timing */ - value = (panel_info.vl_right_margin - 1) << ATMEL_LCDC_HFP_OFFSET; + value = (panel_info.vl_right_margin - 2) << ATMEL_LCDC_HFP_OFFSET; value |= (panel_info.vl_hsync_len - 1) << ATMEL_LCDC_HPW_OFFSET; value |= (panel_info.vl_left_margin - 1); lcdc_writel(panel_info.mmio, ATMEL_LCDC_TIM2, value);