Patchwork [U-Boot,V2] AT49BV322A Flash: the erase regions are in the wrong order.

login
register
mail settings
Submitter David Wu
Date April 13, 2010, 4:34 p.m.
Message ID <op.va30ayfcqigx4y@cyprus.local>
Download mbox | patch
Permalink /patch/71753/
State Not Applicable
Delegated to: Stefan Roese
Headers show

Comments

David Wu - April 13, 2010, 4:34 p.m.
The device id for this Flash is 0xc8.

Signed-off-by: David Wu <davidwu@arcturusnetworks.com>
---
  drivers/mtd/cfi_flash.c |    4 +++-
  1 files changed, 3 insertions(+), 1 deletions(-)

  	if (reverse_geometry)
Stefan Roese - April 14, 2010, 8:42 a.m.
On Tuesday 13 April 2010 18:34:00 David Wu wrote:
>     The device id for this Flash is 0xc8.
> 
> Signed-off-by: David Wu <davidwu@arcturusnetworks.com>
> ---
>   drivers/mtd/cfi_flash.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> index fdba297..af86f99 100644
> --- a/drivers/mtd/cfi_flash.c
> +++ b/drivers/mtd/cfi_flash.c
> @@ -1690,8 +1690,10 @@ static void flash_fixup_atmel(flash_info_t *info,
> struct cfi_qry *qry)

!!!!!!!!!!!!!!!!!!

Sill line wrapped. I could fix this here, but since your other patches are 
also line wrapped you need to fix your mailer setup anyway. Best would be to 
send via "git send-email". If this is not possible, take a look at this for 
correct mail client setup for sending patches:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/email-
clients.txt;h=945ff3fda4337b089515dfced483fee7b941edcf;hb=HEAD

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de

Patch

diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index fdba297..af86f99 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -1690,8 +1690,10 @@  static void flash_fixup_atmel(flash_info_t *info,  
struct cfi_qry *qry)
  	/* AT49BV6416(T) list the erase regions in the wrong order.
  	 * However, the device ID is identical with the non-broken
  	 * AT49BV642D they differ in the high byte.
+	 * AT49BV322A is also in the wrong order.
  	 */
-	if (info->device_id == 0xd6 || info->device_id == 0xd2)
+	if (info->device_id == 0xd6 || info->device_id == 0xd2 ||
+	    info->device_id == 0xc8)
  		reverse_geometry = !reverse_geometry;