diff mbox

SDL2_X11 depends on MMU (fork)

Message ID 20170119215327.10668-1-romain.naour@gmail.com
State Accepted
Headers show

Commit Message

Romain Naour Jan. 19, 2017, 9:53 p.m. UTC
From: Guillaume GARDET <guillaume.gardet@oliseo.fr>

Fixes autobuilder failure http://autobuild.buildroot.net/results/2f7/2f738830bf98eb7284f99c11856a8694467b3daa

Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
Cc: baruch@tkos.co.il
Cc: romain.naour@gmail.com
Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
Guillaume's email sent with git send-email seems rejected by the mailing list server...
---
 package/sdl2/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Jan. 20, 2017, 3:08 a.m. UTC | #1
Hello,

On Thu, 19 Jan 2017 22:53:27 +0100, Romain Naour wrote:
> From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> 
> Fixes autobuilder failure http://autobuild.buildroot.net/results/2f7/2f738830bf98eb7284f99c11856a8694467b3daa
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> Cc: baruch@tkos.co.il
> Cc: romain.naour@gmail.com
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> Guillaume's email sent with git send-email seems rejected by the mailing list server...
> ---
>  package/sdl2/Config.in | 1 +
>  1 file changed, 1 insertion(+)

I've applied, after fixing two things:

 - The commit title did not comply with our usual practice, it was
   lacking a package prefix, "sdl2: ".

 - The depends on BR2_USE_MMU dependency was not provided to the
   Config.in comment as it should have been.

Thanks a lot!

Thomas
Guillaume GARDET Jan. 20, 2017, 9:50 a.m. UTC | #2
Hello,


Le 20/01/2017 à 04:08, Thomas Petazzoni a écrit :
> Hello,
>
> On Thu, 19 Jan 2017 22:53:27 +0100, Romain Naour wrote:
>> From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>>
>> Fixes autobuilder failure http://autobuild.buildroot.net/results/2f7/2f738830bf98eb7284f99c11856a8694467b3daa
>>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>> Cc: baruch@tkos.co.il
>> Cc: romain.naour@gmail.com
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> ---
>> Guillaume's email sent with git send-email seems rejected by the mailing list server...
>> ---
>>   package/sdl2/Config.in | 1 +
>>   1 file changed, 1 insertion(+)
> I've applied, after fixing two things:
Thanks.

>
>   - The commit title did not comply with our usual practice, it was
>     lacking a package prefix, "sdl2: ".
>
>   - The depends on BR2_USE_MMU dependency was not provided to the
>     Config.in comment as it should have been.

Thanks for fixing both.

Guillaume

>
> Thanks a lot!
>
> Thomas
diff mbox

Patch

diff --git a/package/sdl2/Config.in b/package/sdl2/Config.in
index b73611d..1d83c98 100644
--- a/package/sdl2/Config.in
+++ b/package/sdl2/Config.in
@@ -21,6 +21,7 @@  comment "DirectFB video driver needs directfb"
 config BR2_PACKAGE_SDL2_X11
 	bool "X11 video driver"
 	depends on BR2_PACKAGE_XORG7
+	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_XLIB_LIBX11
 	select BR2_PACKAGE_XLIB_LIBXEXT