| Message ID | 1484739184-24211-12-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Not Applicable |
| Delegated to: | Bin Meng |
| Headers | show |
On 18 January 2017 at 04:33, Bin Meng <bmeng.cn@gmail.com> wrote: > SPL prints "Trying to boot from %s" without a LF. Add one to improve > reading on the serial console. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > common/spl/spl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Wed, Jan 25, 2017 at 12:09 PM, Simon Glass <sjg@chromium.org> wrote: > On 18 January 2017 at 04:33, Bin Meng <bmeng.cn@gmail.com> wrote: >> SPL prints "Trying to boot from %s" without a LF. Add one to improve >> reading on the serial console. >> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> --- >> >> common/spl/spl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> Drop this commit, since another commit has been merged to mainstream already: commit cf947da19aecd1b430f22d73ad109af64a6051b5 Author: Andrew F. Davis <afd@ti.com> Date: Thu Jan 12 10:19:55 2017 -0600 spl: Add some missing newlines Signed-off-by: Andrew F. Davis <afd@ti.com> Acked-by: Lokesh Vutla <lokeshvutla@ti.com> Acked-by: Michal Simek <michal.simek@xilinx.com> Regards, Bin
diff --git a/common/spl/spl.c b/common/spl/spl.c index 8fb8da4..1210da3 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -266,7 +266,7 @@ static int boot_from_devices(struct spl_image_info *spl_image, loader = spl_ll_find_loader(spl_boot_list[i]); #if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT) if (loader) - printf("Trying to boot from %s", loader->name); + printf("Trying to boot from %s\n", loader->name); else puts("SPL: Unsupported Boot Device!\n"); #endif
SPL prints "Trying to boot from %s" without a LF. Add one to improve reading on the serial console. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)