diff mbox

[v5,2/2] gdbstub.c: update old error report statements

Message ID 1484726609-16537-1-git-send-email-skiver.cloud.yzy@gmail.com
State New
Headers show

Commit Message

skiver.cloud.yzy@gmail.com Jan. 18, 2017, 8:03 a.m. UTC 
From: Ziyue Yang <yzylivezh@hotmail.com>

Some updates from fprintf(stderr, ...) to error_report.

Signed-off-by: Ziyue Yang <skiver.cloud.yzy@gmail.com>
---
 gdbstub.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

--
2.7.4

Comments

Thomas Huth Jan. 18, 2017, 8:05 a.m. UTC | #1 
On 18.01.2017 09:03, Ziyue Yang wrote:
> From: Ziyue Yang <yzylivezh@hotmail.com>
> 
> Some updates from fprintf(stderr, ...) to error_report.
> 
> Signed-off-by: Ziyue Yang <skiver.cloud.yzy@gmail.com>
> ---
>  gdbstub.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index 426d55e..959f6dc 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -637,8 +637,8 @@ void gdb_register_coprocessor(CPUState *cpu,
>      *p = s;
>      if (g_pos) {
>          if (g_pos != s->base_reg) {
> -            fprintf(stderr, "Error: Bad gdb register numbering for '%s'\n"
> -                    "Expected %d got %d\n", xml, g_pos, s->base_reg);
> +            error_report("Error: Bad gdb register numbering for '%s', "
> +                         "expected %d got %d", xml, g_pos, s->base_reg);
>          } else {
>              cpu->gdb_num_g_regs = cpu->gdb_num_regs;
>          }
> @@ -890,7 +890,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
>          }
>      case 'k':
>          /* Kill the target */
> -        fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
> +        error_report("QEMU: Terminated via GDBstub");
>          exit(0);
>      case 'D':
>          /* Detach packet */
> @@ -1358,8 +1358,8 @@ void gdb_do_syscallv(gdb_syscall_complete_cb cb, const char *fmt, va_list va)
>                  break;
>              default:
>              bad_format:
> -                fprintf(stderr, "gdbstub: Bad syscall format string '%s'\n",
> -                        fmt - 1);
> +                error_report("gdbstub: Bad syscall format string '%s'",
> +                             fmt - 1);
>                  break;
>              }
>          } else {
> --
> 2.7.4

Reviewed-by: Thomas Huth <thuth@redhat.com>
Fam Zheng Jan. 18, 2017, 9:52 a.m. UTC | #2 
On Wed, 01/18 16:03, Ziyue Yang wrote:
> From: Ziyue Yang <yzylivezh@hotmail.com>
> 
> Some updates from fprintf(stderr, ...) to error_report.

In the future, please use "git format-patch --cover-letter" and "git send-email
--thread" to make sure the patches form a thread. See also:

http://wiki.qemu.org/Contribute/SubmitAPatch

Fam
diff mbox

Patch

diff --git a/gdbstub.c b/gdbstub.c
index 426d55e..959f6dc 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -637,8 +637,8 @@  void gdb_register_coprocessor(CPUState *cpu,
     *p = s;
     if (g_pos) {
         if (g_pos != s->base_reg) {
-            fprintf(stderr, "Error: Bad gdb register numbering for '%s'\n"
-                    "Expected %d got %d\n", xml, g_pos, s->base_reg);
+            error_report("Error: Bad gdb register numbering for '%s', "
+                         "expected %d got %d", xml, g_pos, s->base_reg);
         } else {
             cpu->gdb_num_g_regs = cpu->gdb_num_regs;
         }
@@ -890,7 +890,7 @@  static int gdb_handle_packet(GDBState *s, const char *line_buf)
         }
     case 'k':
         /* Kill the target */
-        fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
+        error_report("QEMU: Terminated via GDBstub");
         exit(0);
     case 'D':
         /* Detach packet */
@@ -1358,8 +1358,8 @@  void gdb_do_syscallv(gdb_syscall_complete_cb cb, const char *fmt, va_list va)
                 break;
             default:
             bad_format:
-                fprintf(stderr, "gdbstub: Bad syscall format string '%s'\n",
-                        fmt - 1);
+                error_report("gdbstub: Bad syscall format string '%s'",
+                             fmt - 1);
                 break;
             }
         } else {