diff mbox

[U-Boot] tools: mkimage: fix sizeof_mismatch found by coverity

Message ID 1484678211-16515-1-git-send-email-sven.ebenfeld@gmail.com
State Accepted
Commit b4e923a8056c29ae978c2086b65be0cbc84cef4e
Delegated to: Tom Rini
Headers show

Commit Message

Sven Ebenfeld Jan. 17, 2017, 6:36 p.m. UTC
Reported-by: Coverity (CID: 155214)
Signed-off-by: Sven Ebenfeld <sven.ebenfeld@gmail.com>
---
 tools/mkimage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Jan. 21, 2017, 3:38 a.m. UTC | #1
On Tue, Jan 17, 2017 at 07:36:51PM +0100, Sven Ebenfeld wrote:

> Reported-by: Coverity (CID: 155214)
> Signed-off-by: Sven Ebenfeld <sven.ebenfeld@gmail.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/tools/mkimage.c b/tools/mkimage.c
index f48135f..e9d049e 100644
--- a/tools/mkimage.c
+++ b/tools/mkimage.c
@@ -522,7 +522,7 @@  int main(int argc, char **argv)
 							+ 0x20, 0 };
 			int i = params.file_size;
 			for (; i < aligned_filesize; i++) {
-				if (write(ifd, &i, 1) != 1) {
+				if (write(ifd, (char *) &i, 1) != 1) {
 					fprintf(stderr,
 							"%s: Write error on %s: %s\n",
 							params.cmdname,