Patchwork [MAVERICK,SRU] UBUNTU: SAUCE: enable rfkill for rtl8192se driver

login
register
mail settings
Submitter Manoj Iyer
Date Nov. 17, 2010, 11:19 p.m.
Message ID <AANLkTik=wWKfjRGDJL7QzFS8QgvAKVvLk5fq5X0HQo-p@mail.gmail.com>
Download mbox
Permalink /patch/71632/
State Accepted
Delegated to: Tim Gardner
Headers show

Pull-request

git://kernel.ubuntu.com/git/manjo/ubuntu-maverick.git lp640992

Comments

Manoj Iyer - Nov. 17, 2010, 11:19 p.m.
SRU JUSTIFICAITON
                -D_ENABLE_SW_BEACON                     \
Stefan Bader - Nov. 18, 2010, 8:44 a.m.
On 11/18/2010 12:19 AM, Manoj Iyer wrote:
> SRU JUSTIFICAITON
> ===================
> On thinkpad Edge with RTL8192SE wifi device, wifi on/off hotkey does
> not work. Enabled RFKILL in the rtl8192se module to enable this
> hotkey.
> 
> IMPACT
> =======
> The change is limited to Makefile, it enables -DCONFIG_RTL_RFKILL
> (-DCONFIG_CFG_80211 also need to be enabled as per comment in the
> Makefile).
> 
> TEST
> =====
> The new driver was tested by  Steve Magoun and reported to work. Test
> kernel can be found in,
> http://kernel.ubuntu.com/~manjo/maveric/lp640992/
> 
Hopefully enabling this does not break some hardware that took the chip but
maybe wired differently. I assume we don't have any hardware other than the TP
Edge with a rtl8192se? Just to see it there (still) works. Tentatively

Acked-by: Stefan Bader <stefan.bader@canonical.com>

> The following changes since commit 00ee3793e9b153e3655a58fed9cd8b26f9eb5c6b:
>   Manoj Iyer (1):
>         UBUNTU: SAUCE: enable rfkill for rtl8192se driver
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/git/manjo/ubuntu-maverick.git lp640992
> 
> From 00ee3793e9b153e3655a58fed9cd8b26f9eb5c6b Mon Sep 17 00:00:00 2001
> From: Manoj Iyer <manoj.iyer@canonical.com>
> Date: Wed, 17 Nov 2010 23:02:38 +0000
> Subject: [PATCH] UBUNTU: SAUCE: enable rfkill for rtl8192se driver
> 
> This driver is not upstream, it is part of the ubuntu delta.
> 
> BugLink: http://bugs.launchpad.net/bugs/640992
> 
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> ---
>  ubuntu/rtl8192se/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ubuntu/rtl8192se/Makefile b/ubuntu/rtl8192se/Makefile
> index c1490b9..8d3c15c 100755
> --- a/ubuntu/rtl8192se/Makefile
> +++ b/ubuntu/rtl8192se/Makefile
> @@ -67,10 +67,10 @@ EXTRA_CFLAGS += -DEEPROM_OLD_FORMAT_SUPPORT=0
>          \
>                 -DENABLE_DOT11D                         \
>                 -DCONFIG_ASPM_OR_D3                     \
>                 -DRTLLIB_RADIOTAP                       \
> -               #                                       \
> -               -DCONFIG_CRDA                           \
>                 -DCONFIG_CFG_80211                      \
>                 -DCONFIG_RTL_RFKILL                     \
> +               #                                       \
> +               -DCONFIG_CRDA                           \
>                 -DCONFIG_FW_SETCHAN                     \
>                 -DRTL8192S_WAPI_SUPPORT                 \
>                 -D_ENABLE_SW_BEACON                     \
Tim Gardner - Nov. 18, 2010, 1:57 p.m.
On 11/18/2010 01:44 AM, Stefan Bader wrote:
> On 11/18/2010 12:19 AM, Manoj Iyer wrote:
>> SRU JUSTIFICAITON
>> ===================
>> On thinkpad Edge with RTL8192SE wifi device, wifi on/off hotkey does
>> not work. Enabled RFKILL in the rtl8192se module to enable this
>> hotkey.
>>
>> IMPACT
>> =======
>> The change is limited to Makefile, it enables -DCONFIG_RTL_RFKILL
>> (-DCONFIG_CFG_80211 also need to be enabled as per comment in the
>> Makefile).
>>
>> TEST
>> =====
>> The new driver was tested by  Steve Magoun and reported to work. Test
>> kernel can be found in,
>> http://kernel.ubuntu.com/~manjo/maveric/lp640992/
>>
> Hopefully enabling this does not break some hardware that took the chip but
> maybe wired differently. I assume we don't have any hardware other than the TP
> Edge with a rtl8192se? Just to see it there (still) works. Tentatively
>
> Acked-by: Stefan Bader<stefan.bader@canonical.com>
>
>> The following changes since commit 00ee3793e9b153e3655a58fed9cd8b26f9eb5c6b:
>>    Manoj Iyer (1):
>>          UBUNTU: SAUCE: enable rfkill for rtl8192se driver
>>
>> are available in the git repository at:
>>
>>    git://kernel.ubuntu.com/git/manjo/ubuntu-maverick.git lp640992
>>
>>  From 00ee3793e9b153e3655a58fed9cd8b26f9eb5c6b Mon Sep 17 00:00:00 2001
>> From: Manoj Iyer<manoj.iyer@canonical.com>
>> Date: Wed, 17 Nov 2010 23:02:38 +0000
>> Subject: [PATCH] UBUNTU: SAUCE: enable rfkill for rtl8192se driver
>>
>> This driver is not upstream, it is part of the ubuntu delta.
>>
>> BugLink: http://bugs.launchpad.net/bugs/640992
>>
>> Signed-off-by: Manoj Iyer<manoj.iyer@canonical.com>
>> ---
>>   ubuntu/rtl8192se/Makefile |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/ubuntu/rtl8192se/Makefile b/ubuntu/rtl8192se/Makefile
>> index c1490b9..8d3c15c 100755
>> --- a/ubuntu/rtl8192se/Makefile
>> +++ b/ubuntu/rtl8192se/Makefile
>> @@ -67,10 +67,10 @@ EXTRA_CFLAGS += -DEEPROM_OLD_FORMAT_SUPPORT=0
>>           \
>>                  -DENABLE_DOT11D                         \
>>                  -DCONFIG_ASPM_OR_D3                     \
>>                  -DRTLLIB_RADIOTAP                       \
>> -               #                                       \
>> -               -DCONFIG_CRDA                           \
>>                  -DCONFIG_CFG_80211                      \
>>                  -DCONFIG_RTL_RFKILL                     \
>> +               #                                       \
>> +               -DCONFIG_CRDA                           \
>>                  -DCONFIG_FW_SETCHAN                     \
>>                  -DRTL8192S_WAPI_SUPPORT                 \
>>                  -D_ENABLE_SW_BEACON                     \
>
>

Ack - applied and pushed