| Message ID | 20170117155019.47932-2-manu@bidouilliste.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
Am 17.01.2017 um 16:50 schrieb Emmanuel Vadot: > Add kconfig file to enable API support > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > --- > Kconfig | 2 ++ > api/Kconfig | 9 +++++++++ > 2 files changed, 11 insertions(+) > create mode 100644 api/Kconfig > > diff --git a/Kconfig b/Kconfig > index 39a4d938d8..6a93d8820f 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY > > endmenu # Boot images > > +source "api/Kconfig" > + > source "common/Kconfig" > > source "cmd/Kconfig" > diff --git a/api/Kconfig b/api/Kconfig > new file mode 100644 > index 0000000000..88b4f6c4e5 > --- /dev/null > +++ b/api/Kconfig > @@ -0,0 +1,9 @@ > +menu "API" > + > +config API > + bool "Enable U-Boot API" > + default n > + help > + This option enable the U-Boot API. "enables" Should the help say, e.g., "userspace API" for clarity? > + > +endmenu Otherwise looks okay, obviously. Regards, Andreas
Hi Andreas, On Tue, 17 Jan 2017 18:16:58 +0100 Andreas Färber <afaerber@suse.de> wrote: > Am 17.01.2017 um 16:50 schrieb Emmanuel Vadot: > > Add kconfig file to enable API support > > > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > > --- > > Kconfig | 2 ++ > > api/Kconfig | 9 +++++++++ > > 2 files changed, 11 insertions(+) > > create mode 100644 api/Kconfig > > > > diff --git a/Kconfig b/Kconfig > > index 39a4d938d8..6a93d8820f 100644 > > --- a/Kconfig > > +++ b/Kconfig > > @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY > > > > endmenu # Boot images > > > > +source "api/Kconfig" > > + > > source "common/Kconfig" > > > > source "cmd/Kconfig" > > diff --git a/api/Kconfig b/api/Kconfig > > new file mode 100644 > > index 0000000000..88b4f6c4e5 > > --- /dev/null > > +++ b/api/Kconfig > > @@ -0,0 +1,9 @@ > > +menu "API" > > + > > +config API > > + bool "Enable U-Boot API" > > + default n > > + help > > + This option enable the U-Boot API. > > "enables" I'll change that, thanks for reviewing. > Should the help say, e.g., "userspace API" for clarity? I don't know, I'm for whatever is best. > > > + > > +endmenu > > Otherwise looks okay, obviously. > > Regards, > Andreas > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg)
On Tue, Jan 17, 2017 at 12:40 PM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > > Hi Andreas, > > On Tue, 17 Jan 2017 18:16:58 +0100 > Andreas Färber <afaerber@suse.de> wrote: > >> Am 17.01.2017 um 16:50 schrieb Emmanuel Vadot: >> > Add kconfig file to enable API support >> > >> > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> >> > --- >> > Kconfig | 2 ++ >> > api/Kconfig | 9 +++++++++ >> > 2 files changed, 11 insertions(+) >> > create mode 100644 api/Kconfig >> > >> > diff --git a/Kconfig b/Kconfig >> > index 39a4d938d8..6a93d8820f 100644 >> > --- a/Kconfig >> > +++ b/Kconfig >> > @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY >> > >> > endmenu # Boot images >> > >> > +source "api/Kconfig" >> > + >> > source "common/Kconfig" >> > >> > source "cmd/Kconfig" >> > diff --git a/api/Kconfig b/api/Kconfig >> > new file mode 100644 >> > index 0000000000..88b4f6c4e5 >> > --- /dev/null >> > +++ b/api/Kconfig >> > @@ -0,0 +1,9 @@ >> > +menu "API" >> > + >> > +config API >> > + bool "Enable U-Boot API" >> > + default n >> > + help >> > + This option enable the U-Boot API. >> >> "enables" > > I'll change that, thanks for reviewing. > >> Should the help say, e.g., "userspace API" for clarity? > > I don't know, I'm for whatever is best. It isn't a userspace API, per se, since it isn't used after the kernel is loaded and booted. It's likely to lead to confusion if use use that term. The README file calls it "U-Boot machine/arch independent API for external apps" FWIW, so maybe some variation on that might make the help text better. Warner Losh <imp@freebsd.org> >> > + >> > +endmenu >> >> Otherwise looks okay, obviously. >> >> Regards, >> Andreas >> >> -- >> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany >> GF: Felix Imendörffer, Jane Smithard, Graham Norton >> HRB 21284 (AG Nürnberg) > > > -- > Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Hi, On 17 January 2017 at 08:50, Emmanuel Vadot <manu@bidouilliste.com> wrote: > Add kconfig file to enable API support > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > --- > Kconfig | 2 ++ > api/Kconfig | 9 +++++++++ > 2 files changed, 11 insertions(+) > create mode 100644 api/Kconfig > > diff --git a/Kconfig b/Kconfig > index 39a4d938d8..6a93d8820f 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY > > endmenu # Boot images > > +source "api/Kconfig" > + > source "common/Kconfig" > > source "cmd/Kconfig" > diff --git a/api/Kconfig b/api/Kconfig > new file mode 100644 > index 0000000000..88b4f6c4e5 > --- /dev/null > +++ b/api/Kconfig > @@ -0,0 +1,9 @@ > +menu "API" > + > +config API > + bool "Enable U-Boot API" > + default n > + help > + This option enable the U-Boot API. Can you add a little detail about what the API is and what it is for? Also, are you going to migrate all boards to use Kconfig for this option and drop it from the whitelist? > + > +endmenu > -- > 2.11.0 > Regards, Simon
On Fri, Jan 20, 2017 at 8:51 PM, Simon Glass <sjg@chromium.org> wrote: > Hi, > > On 17 January 2017 at 08:50, Emmanuel Vadot <manu@bidouilliste.com> wrote: >> Add kconfig file to enable API support >> >> Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> >> --- >> Kconfig | 2 ++ >> api/Kconfig | 9 +++++++++ >> 2 files changed, 11 insertions(+) >> create mode 100644 api/Kconfig >> >> diff --git a/Kconfig b/Kconfig >> index 39a4d938d8..6a93d8820f 100644 >> --- a/Kconfig >> +++ b/Kconfig >> @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY >> >> endmenu # Boot images >> >> +source "api/Kconfig" >> + >> source "common/Kconfig" >> >> source "cmd/Kconfig" >> diff --git a/api/Kconfig b/api/Kconfig >> new file mode 100644 >> index 0000000000..88b4f6c4e5 >> --- /dev/null >> +++ b/api/Kconfig >> @@ -0,0 +1,9 @@ >> +menu "API" >> + >> +config API >> + bool "Enable U-Boot API" >> + default n >> + help >> + This option enable the U-Boot API. > > Can you add a little detail about what the API is and what it is for? You can find complete documentation in the api directory. In brief, it allows the loaded binary to call back into the loader to do generic things like send network packets or read blocks from mass storage. > Also, are you going to migrate all boards to use Kconfig for this > option and drop it from the whitelist? I'll leave that to Emmanuel. Warner >> + >> +endmenu >> -- >> 2.11.0 >> > > Regards, > Simon
On Fri, 20 Jan 2017 20:51:48 -0700 Simon Glass <sjg@chromium.org> wrote: > Hi, > > On 17 January 2017 at 08:50, Emmanuel Vadot <manu@bidouilliste.com> wrote: > > Add kconfig file to enable API support > > > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > > --- > > Kconfig | 2 ++ > > api/Kconfig | 9 +++++++++ > > 2 files changed, 11 insertions(+) > > create mode 100644 api/Kconfig > > > > diff --git a/Kconfig b/Kconfig > > index 39a4d938d8..6a93d8820f 100644 > > --- a/Kconfig > > +++ b/Kconfig > > @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY > > > > endmenu # Boot images > > > > +source "api/Kconfig" > > + > > source "common/Kconfig" > > > > source "cmd/Kconfig" > > diff --git a/api/Kconfig b/api/Kconfig > > new file mode 100644 > > index 0000000000..88b4f6c4e5 > > --- /dev/null > > +++ b/api/Kconfig > > @@ -0,0 +1,9 @@ > > +menu "API" > > + > > +config API > > + bool "Enable U-Boot API" > > + default n > > + help > > + This option enable the U-Boot API. > > Can you add a little detail about what the API is and what it is for? > > Also, are you going to migrate all boards to use Kconfig for this > option and drop it from the whitelist? I don't understand your question about migration, currently no board are using it. As for the whitelist, if I understand correctly how it works it should be removed in the same patch. > > + > > +endmenu > > -- > > 2.11.0 > > > > Regards, > Simon
On Sat, Jan 21, 2017 at 09:22:47PM -0700, Warner Losh wrote: > On Fri, Jan 20, 2017 at 8:51 PM, Simon Glass <sjg@chromium.org> wrote: > > Hi, > > > > On 17 January 2017 at 08:50, Emmanuel Vadot <manu@bidouilliste.com> wrote: > >> Add kconfig file to enable API support > >> > >> Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > >> --- > >> Kconfig | 2 ++ > >> api/Kconfig | 9 +++++++++ > >> 2 files changed, 11 insertions(+) > >> create mode 100644 api/Kconfig > >> > >> diff --git a/Kconfig b/Kconfig > >> index 39a4d938d8..6a93d8820f 100644 > >> --- a/Kconfig > >> +++ b/Kconfig > >> @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY > >> > >> endmenu # Boot images > >> > >> +source "api/Kconfig" > >> + > >> source "common/Kconfig" > >> > >> source "cmd/Kconfig" > >> diff --git a/api/Kconfig b/api/Kconfig > >> new file mode 100644 > >> index 0000000000..88b4f6c4e5 > >> --- /dev/null > >> +++ b/api/Kconfig > >> @@ -0,0 +1,9 @@ > >> +menu "API" > >> + > >> +config API > >> + bool "Enable U-Boot API" > >> + default n > >> + help > >> + This option enable the U-Boot API. > > > > Can you add a little detail about what the API is and what it is for? > > You can find complete documentation in the api directory. In brief, it > allows the loaded binary to call back into the loader to do generic > things like send network packets or read blocks from mass storage. Right. Can you re-word the "In brief.." slightly so it reads well under the 'help' section and point to api/README for more details please? > > Also, are you going to migrate all boards to use Kconfig for this > > option and drop it from the whitelist? > > I'll leave that to Emmanuel. There's two boards that enable API today but tools/moveconfig.py may be more overhead than just editing configs/PMC440_defconfig and configs/lsxhl_defconfig (and the respective include/configs/ files).
Hi Tom, On Mon, 23 Jan 2017 09:51:59 -0500 Tom Rini <trini@konsulko.com> wrote: > On Sat, Jan 21, 2017 at 09:22:47PM -0700, Warner Losh wrote: > > On Fri, Jan 20, 2017 at 8:51 PM, Simon Glass <sjg@chromium.org> wrote: > > > Hi, > > > > > > On 17 January 2017 at 08:50, Emmanuel Vadot <manu@bidouilliste.com> wrote: > > >> Add kconfig file to enable API support > > >> > > >> Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > > >> --- > > >> Kconfig | 2 ++ > > >> api/Kconfig | 9 +++++++++ > > >> 2 files changed, 11 insertions(+) > > >> create mode 100644 api/Kconfig > > >> > > >> diff --git a/Kconfig b/Kconfig > > >> index 39a4d938d8..6a93d8820f 100644 > > >> --- a/Kconfig > > >> +++ b/Kconfig > > >> @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY > > >> > > >> endmenu # Boot images > > >> > > >> +source "api/Kconfig" > > >> + > > >> source "common/Kconfig" > > >> > > >> source "cmd/Kconfig" > > >> diff --git a/api/Kconfig b/api/Kconfig > > >> new file mode 100644 > > >> index 0000000000..88b4f6c4e5 > > >> --- /dev/null > > >> +++ b/api/Kconfig > > >> @@ -0,0 +1,9 @@ > > >> +menu "API" > > >> + > > >> +config API > > >> + bool "Enable U-Boot API" > > >> + default n > > >> + help > > >> + This option enable the U-Boot API. > > > > > > Can you add a little detail about what the API is and what it is for? > > > > You can find complete documentation in the api directory. In brief, it > > allows the loaded binary to call back into the loader to do generic > > things like send network packets or read blocks from mass storage. > > Right. Can you re-word the "In brief.." slightly so it reads well under > the 'help' section and point to api/README for more details please? All right, I'll do that for v3. > > > Also, are you going to migrate all boards to use Kconfig for this > > > option and drop it from the whitelist? > > > > I'll leave that to Emmanuel. > > There's two boards that enable API today but tools/moveconfig.py may be > more overhead than just editing configs/PMC440_defconfig and > configs/lsxhl_defconfig (and the respective include/configs/ files). > > -- > Tom Ah, I've missed those. Would it make more sense to submit a patch that handle adding CONFIG_API into Kconfig (and changing configs for those two board and remove from the whitelist) separate from the FreeBSD config sets of patches ? Thanks,
On Mon, Jan 23, 2017 at 05:05:50PM +0100, Emmanuel Vadot wrote: > > Hi Tom, > > On Mon, 23 Jan 2017 09:51:59 -0500 > Tom Rini <trini@konsulko.com> wrote: > > > On Sat, Jan 21, 2017 at 09:22:47PM -0700, Warner Losh wrote: > > > On Fri, Jan 20, 2017 at 8:51 PM, Simon Glass <sjg@chromium.org> wrote: > > > > Hi, > > > > > > > > On 17 January 2017 at 08:50, Emmanuel Vadot <manu@bidouilliste.com> wrote: > > > >> Add kconfig file to enable API support > > > >> > > > >> Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > > > >> --- > > > >> Kconfig | 2 ++ > > > >> api/Kconfig | 9 +++++++++ > > > >> 2 files changed, 11 insertions(+) > > > >> create mode 100644 api/Kconfig > > > >> > > > >> diff --git a/Kconfig b/Kconfig > > > >> index 39a4d938d8..6a93d8820f 100644 > > > >> --- a/Kconfig > > > >> +++ b/Kconfig > > > >> @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY > > > >> > > > >> endmenu # Boot images > > > >> > > > >> +source "api/Kconfig" > > > >> + > > > >> source "common/Kconfig" > > > >> > > > >> source "cmd/Kconfig" > > > >> diff --git a/api/Kconfig b/api/Kconfig > > > >> new file mode 100644 > > > >> index 0000000000..88b4f6c4e5 > > > >> --- /dev/null > > > >> +++ b/api/Kconfig > > > >> @@ -0,0 +1,9 @@ > > > >> +menu "API" > > > >> + > > > >> +config API > > > >> + bool "Enable U-Boot API" > > > >> + default n > > > >> + help > > > >> + This option enable the U-Boot API. > > > > > > > > Can you add a little detail about what the API is and what it is for? > > > > > > You can find complete documentation in the api directory. In brief, it > > > allows the loaded binary to call back into the loader to do generic > > > things like send network packets or read blocks from mass storage. > > > > Right. Can you re-word the "In brief.." slightly so it reads well under > > the 'help' section and point to api/README for more details please? > > All right, I'll do that for v3. > > > > > Also, are you going to migrate all boards to use Kconfig for this > > > > option and drop it from the whitelist? > > > > > > I'll leave that to Emmanuel. > > > > There's two boards that enable API today but tools/moveconfig.py may be > > more overhead than just editing configs/PMC440_defconfig and > > configs/lsxhl_defconfig (and the respective include/configs/ files). > > Ah, I've missed those. Would it make more sense to submit a patch that > handle adding CONFIG_API into Kconfig (and changing configs for those > two board and remove from the whitelist) separate from the FreeBSD > config sets of patches ? It's up to you guys. I want to see this thread sorted out and changes required to support FreeBSD happily, out of the box, in. So API gets converted one way or another :)
diff --git a/Kconfig b/Kconfig index 39a4d938d8..6a93d8820f 100644 --- a/Kconfig +++ b/Kconfig @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY endmenu # Boot images +source "api/Kconfig" + source "common/Kconfig" source "cmd/Kconfig" diff --git a/api/Kconfig b/api/Kconfig new file mode 100644 index 0000000000..88b4f6c4e5 --- /dev/null +++ b/api/Kconfig @@ -0,0 +1,9 @@ +menu "API" + +config API + bool "Enable U-Boot API" + default n + help + This option enable the U-Boot API. + +endmenu
Add kconfig file to enable API support Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> --- Kconfig | 2 ++ api/Kconfig | 9 +++++++++ 2 files changed, 11 insertions(+) create mode 100644 api/Kconfig