diff mbox

[U-Boot] drivers: usb: gadget: ether: Fix compiler warning

Message ID 20170117032122.8383-1-lokeshvutla@ti.com
State Accepted
Commit 65c389d27902f6376bd057609b66b7339b219cf1
Delegated to: Ɓukasz Majewski
Headers show

Commit Message

Lokesh Vutla Jan. 17, 2017, 3:21 a.m. UTC
Latest gcc 6.2 compiler is throwing the below warning for am335x_baltos_defconfig
drivers/usb/gadget/ether.c:501:17: warning: 'mdlm_detail_desc' defined but not used [-Wunused-const-variable=]
 static const u8 mdlm_detail_desc[] = {

Guard mdlm_detail_desc with CONFIG_USB_ETH_SUBSET to avoid the warning

Reported-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 drivers/usb/gadget/ether.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Marek Vasut Jan. 17, 2017, 9:26 a.m. UTC | #1
On 01/17/2017 04:21 AM, Lokesh Vutla wrote:
> Latest gcc 6.2 compiler is throwing the below warning for am335x_baltos_defconfig
> drivers/usb/gadget/ether.c:501:17: warning: 'mdlm_detail_desc' defined but not used [-Wunused-const-variable=]
>  static const u8 mdlm_detail_desc[] = {
> 
> Guard mdlm_detail_desc with CONFIG_USB_ETH_SUBSET to avoid the warning
> 
> Reported-by: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
>  drivers/usb/gadget/ether.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
> index f1b0709821..4137d76c42 100644
> --- a/drivers/usb/gadget/ether.c
> +++ b/drivers/usb/gadget/ether.c
> @@ -507,6 +507,7 @@ static const struct usb_cdc_mdlm_desc mdlm_desc = {
>   * can't really use its struct.  All we do here is say that we're using
>   * the submode of "SAFE" which directly matches the CDC Subset.
>   */
> +#ifdef CONFIG_USB_ETH_SUBSET
>  static const u8 mdlm_detail_desc[] = {
>  	6,
>  	USB_DT_CS_INTERFACE,
> @@ -516,6 +517,7 @@ static const u8 mdlm_detail_desc[] = {
>  	0,	/* network control capabilities (none) */
>  	0,	/* network data capabilities ("raw" encapsulation) */
>  };
> +#endif
>  
>  #endif
>  
> 
Applied, thanks.
diff mbox

Patch

diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
index f1b0709821..4137d76c42 100644
--- a/drivers/usb/gadget/ether.c
+++ b/drivers/usb/gadget/ether.c
@@ -507,6 +507,7 @@  static const struct usb_cdc_mdlm_desc mdlm_desc = {
  * can't really use its struct.  All we do here is say that we're using
  * the submode of "SAFE" which directly matches the CDC Subset.
  */
+#ifdef CONFIG_USB_ETH_SUBSET
 static const u8 mdlm_detail_desc[] = {
 	6,
 	USB_DT_CS_INTERFACE,
@@ -516,6 +517,7 @@  static const u8 mdlm_detail_desc[] = {
 	0,	/* network control capabilities (none) */
 	0,	/* network data capabilities ("raw" encapsulation) */
 };
+#endif
 
 #endif