| Message ID | 20170115203435.908-2-joerg.krause@embedded.rocks |
|---|---|
| State | Accepted |
| Commit | d0774df0918d9a159ecab21cc2290f81bc4850f1 |
| Headers | show |
Jörg, All, On 2017-01-15 21:34 +0100, Jörg Krause spake thusly: > Version 0.20.x does not depend on libglib2 anymore. Note, that the > dependency on MMU and Thread remain, as MPD uses fork() and thread > functionality. This patch should be folded in the previous one. Regards, Yann E. MORIN. > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > --- > package/mpd/Config.in | 7 +++---- > package/mpd/mpd.mk | 2 +- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/package/mpd/Config.in b/package/mpd/Config.in > index e0bb60447..9b22f68ce 100644 > --- a/package/mpd/Config.in > +++ b/package/mpd/Config.in > @@ -1,13 +1,12 @@ > menuconfig BR2_PACKAGE_MPD > bool "mpd" > depends on BR2_INSTALL_LIBSTDCPP > - depends on BR2_USE_WCHAR # libglib2, flac > - depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 > - depends on BR2_USE_MMU # libglib2 > + depends on BR2_USE_WCHAR # flac > + depends on BR2_TOOLCHAIN_HAS_THREADS > + depends on BR2_USE_MMU # fork > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14 > depends on BR2_TOOLCHAIN_HAS_ATOMIC > select BR2_PACKAGE_BOOST > - select BR2_PACKAGE_LIBGLIB2 > select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE > select BR2_PACKAGE_MPD_TREMOR if !(BR2_PACKAGE_MPD_MAD || BR2_PACKAGE_MPD_MPG123 || BR2_PACKAGE_MPD_VORBIS || BR2_PACKAGE_MPD_WAVPACK || BR2_PACKAGE_MPD_FLAC || BR2_PACKAGE_MPD_MUSEPACK || BR2_PACKAGE_MPD_FFMPEG) > help > diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk > index 82aca9665..446973730 100644 > --- a/package/mpd/mpd.mk > +++ b/package/mpd/mpd.mk > @@ -8,7 +8,7 @@ MPD_VERSION_MAJOR = 0.20 > MPD_VERSION = $(MPD_VERSION_MAJOR).2 > MPD_SOURCE = mpd-$(MPD_VERSION).tar.xz > MPD_SITE = http://www.musicpd.org/download/mpd/$(MPD_VERSION_MAJOR) > -MPD_DEPENDENCIES = host-pkgconf boost libglib2 > +MPD_DEPENDENCIES = host-pkgconf boost > MPD_LICENSE = GPLv2+ > MPD_LICENSE_FILES = COPYING > MPD_AUTORECONF = YES > -- > 2.11.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Yann, On Sun, 2017-01-15 at 22:12 +0100, Yann E. MORIN wrote: > Jörg, All, > > On 2017-01-15 21:34 +0100, Jörg Krause spake thusly: > > Version 0.20.x does not depend on libglib2 anymore. Note, that the > > dependency on MMU and Thread remain, as MPD uses fork() and thread > > functionality. > > This patch should be folded in the previous one. Note, that MPD has been bumped to version 0.20 some days ago. I agree, that this would have been the right place to remove the dependency, too. Now, it is just a bump from version 0.20 to 0.20.2. I seperated the two issues to make more clear that libglib2 was *not* dropped in 0.20.2, but already in 0.20. Jörg > > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > > --- > > package/mpd/Config.in | 7 +++---- > > package/mpd/mpd.mk | 2 +- > > 2 files changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/package/mpd/Config.in b/package/mpd/Config.in > > index e0bb60447..9b22f68ce 100644 > > --- a/package/mpd/Config.in > > +++ b/package/mpd/Config.in > > @@ -1,13 +1,12 @@ > > menuconfig BR2_PACKAGE_MPD > > bool "mpd" > > depends on BR2_INSTALL_LIBSTDCPP > > - depends on BR2_USE_WCHAR # libglib2, flac > > - depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 > > - depends on BR2_USE_MMU # libglib2 > > + depends on BR2_USE_WCHAR # flac > > + depends on BR2_TOOLCHAIN_HAS_THREADS > > + depends on BR2_USE_MMU # fork > > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14 > > depends on BR2_TOOLCHAIN_HAS_ATOMIC > > select BR2_PACKAGE_BOOST > > - select BR2_PACKAGE_LIBGLIB2 > > select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE > > select BR2_PACKAGE_MPD_TREMOR if !(BR2_PACKAGE_MPD_MAD || > > BR2_PACKAGE_MPD_MPG123 || BR2_PACKAGE_MPD_VORBIS || > > BR2_PACKAGE_MPD_WAVPACK || BR2_PACKAGE_MPD_FLAC || > > BR2_PACKAGE_MPD_MUSEPACK || BR2_PACKAGE_MPD_FFMPEG) > > help > > diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk > > index 82aca9665..446973730 100644 > > --- a/package/mpd/mpd.mk > > +++ b/package/mpd/mpd.mk > > @@ -8,7 +8,7 @@ MPD_VERSION_MAJOR = 0.20 > > MPD_VERSION = $(MPD_VERSION_MAJOR).2 > > MPD_SOURCE = mpd-$(MPD_VERSION).tar.xz > > MPD_SITE = http://www.musicpd.org/download/mpd/$(MPD_VERSION_MAJOR > > ) > > -MPD_DEPENDENCIES = host-pkgconf boost libglib2 > > +MPD_DEPENDENCIES = host-pkgconf boost > > MPD_LICENSE = GPLv2+ > > MPD_LICENSE_FILES = COPYING > > MPD_AUTORECONF = YES > > -- > > 2.11.0 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > >
>>>>> "Jörg" == Jörg Krause <joerg.krause@embedded.rocks> writes: > Version 0.20.x does not depend on libglib2 anymore. Note, that the > dependency on MMU and Thread remain, as MPD uses fork() and thread > functionality. > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> Committed, thanks.
diff --git a/package/mpd/Config.in b/package/mpd/Config.in index e0bb60447..9b22f68ce 100644 --- a/package/mpd/Config.in +++ b/package/mpd/Config.in @@ -1,13 +1,12 @@ menuconfig BR2_PACKAGE_MPD bool "mpd" depends on BR2_INSTALL_LIBSTDCPP - depends on BR2_USE_WCHAR # libglib2, flac - depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 - depends on BR2_USE_MMU # libglib2 + depends on BR2_USE_WCHAR # flac + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_USE_MMU # fork depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14 depends on BR2_TOOLCHAIN_HAS_ATOMIC select BR2_PACKAGE_BOOST - select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE select BR2_PACKAGE_MPD_TREMOR if !(BR2_PACKAGE_MPD_MAD || BR2_PACKAGE_MPD_MPG123 || BR2_PACKAGE_MPD_VORBIS || BR2_PACKAGE_MPD_WAVPACK || BR2_PACKAGE_MPD_FLAC || BR2_PACKAGE_MPD_MUSEPACK || BR2_PACKAGE_MPD_FFMPEG) help diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk index 82aca9665..446973730 100644 --- a/package/mpd/mpd.mk +++ b/package/mpd/mpd.mk @@ -8,7 +8,7 @@ MPD_VERSION_MAJOR = 0.20 MPD_VERSION = $(MPD_VERSION_MAJOR).2 MPD_SOURCE = mpd-$(MPD_VERSION).tar.xz MPD_SITE = http://www.musicpd.org/download/mpd/$(MPD_VERSION_MAJOR) -MPD_DEPENDENCIES = host-pkgconf boost libglib2 +MPD_DEPENDENCIES = host-pkgconf boost MPD_LICENSE = GPLv2+ MPD_LICENSE_FILES = COPYING MPD_AUTORECONF = YES
Version 0.20.x does not depend on libglib2 anymore. Note, that the dependency on MMU and Thread remain, as MPD uses fork() and thread functionality. Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> --- package/mpd/Config.in | 7 +++---- package/mpd/mpd.mk | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-)