diff mbox

[iproute2] tc: flower: Fix flower output for src and dst ports

Message ID 1484490229-19712-1-git-send-email-roid@mellanox.com
State Accepted, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Roi Dayan Jan. 15, 2017, 2:23 p.m. UTC
This fix a missing use case after the introduction of enum flower_endpoint.

Fixes: 6910d65661a3 ("tc: flower: introduce enum flower_endpoint")
Signed-off-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Paul Blakey <paulb@mellanox.com>
---
 tc/f_flower.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Horman Jan. 24, 2017, 8:42 a.m. UTC | #1
On Sun, Jan 15, 2017 at 04:23:49PM +0200, Roi Dayan wrote:
> This fix a missing use case after the introduction of enum flower_endpoint.
> 
> Fixes: 6910d65661a3 ("tc: flower: introduce enum flower_endpoint")
> Signed-off-by: Roi Dayan <roid@mellanox.com>
> Signed-off-by: Paul Blakey <paulb@mellanox.com>

Thanks, sorry for missing that:

Reviewed-by: Simon Horman <simon.horman@netronome.com>

> ---
>  tc/f_flower.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tc/f_flower.c b/tc/f_flower.c
> index 71e9515..1dbc532 100644
> --- a/tc/f_flower.c
> +++ b/tc/f_flower.c
> @@ -744,10 +744,10 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
>  			     tb[TCA_FLOWER_KEY_IPV6_SRC],
>  			     tb[TCA_FLOWER_KEY_IPV6_SRC_MASK]);
>  
> -	nl_type = flower_port_attr_type(ip_proto, false);
> +	nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_DST);
>  	if (nl_type >= 0)
>  		flower_print_port(f, "dst_port", tb[nl_type]);
> -	nl_type = flower_port_attr_type(ip_proto, true);
> +	nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_SRC);
>  	if (nl_type >= 0)
>  		flower_print_port(f, "src_port", tb[nl_type]);
>  
> -- 
> 1.7.1
>
diff mbox

Patch

diff --git a/tc/f_flower.c b/tc/f_flower.c
index 71e9515..1dbc532 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -744,10 +744,10 @@  static int flower_print_opt(struct filter_util *qu, FILE *f,
 			     tb[TCA_FLOWER_KEY_IPV6_SRC],
 			     tb[TCA_FLOWER_KEY_IPV6_SRC_MASK]);
 
-	nl_type = flower_port_attr_type(ip_proto, false);
+	nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_DST);
 	if (nl_type >= 0)
 		flower_print_port(f, "dst_port", tb[nl_type]);
-	nl_type = flower_port_attr_type(ip_proto, true);
+	nl_type = flower_port_attr_type(ip_proto, FLOWER_ENDPOINT_SRC);
 	if (nl_type >= 0)
 		flower_print_port(f, "src_port", tb[nl_type]);