| Message ID | 1484311084-31547-5-git-send-email-bgolaszewski@baylibre.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Hello, On Fri, Jan 13, 2017 at 01:37:58PM +0100, Bartosz Golaszewski wrote: > The sata core driver already retries to resume the link because some > controllers ignore writes to the SControl register. > > We have a use case with the da850 SATA controller where at PLL0 > frequency of 456MHz (needed to properly service the LCD controller) > the chip becomes unstable and the hardreset operation is ignored the > first time 50% of times. > > Retrying just the resume operation doesn't work - we need to issue > the phy/wake reset again to make it work. > > If ata_phys_link_offline() returns true in sata_link_hardreset(), > retry a couple times before really giving up. I think it'd be better to implement the driver specific implementation rather than changing the behavior for everybody. Thanks.
2017-01-16 0:10 GMT+01:00 Tejun Heo <tj@kernel.org>: > Hello, > > On Fri, Jan 13, 2017 at 01:37:58PM +0100, Bartosz Golaszewski wrote: >> The sata core driver already retries to resume the link because some >> controllers ignore writes to the SControl register. >> >> We have a use case with the da850 SATA controller where at PLL0 >> frequency of 456MHz (needed to properly service the LCD controller) >> the chip becomes unstable and the hardreset operation is ignored the >> first time 50% of times. >> >> Retrying just the resume operation doesn't work - we need to issue >> the phy/wake reset again to make it work. >> >> If ata_phys_link_offline() returns true in sata_link_hardreset(), >> retry a couple times before really giving up. > > I think it'd be better to implement the driver specific implementation > rather than changing the behavior for everybody. > > Thanks. > For v2 I created a new ahci-locally exported function: ahci_do_hardreset() that allows to retrieve the online state of the link and used it in the da850-specific hardreset implementation. Hope that'll be good. Thanks, Bartosz Golaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 9cd0a2d..3b848a3 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -3985,8 +3985,8 @@ int sata_link_hardreset(struct ata_link *link, const unsigned long *timing, unsigned long deadline, bool *online, int (*check_ready)(struct ata_link *)) { + int rc, retry = ATA_LINK_RESET_TRIES; u32 scontrol; - int rc; DPRINTK("ENTER\n"); @@ -4009,7 +4009,7 @@ int sata_link_hardreset(struct ata_link *link, const unsigned long *timing, sata_set_spd(link); } - +retry: /* issue phy wake/reset */ if ((rc = sata_scr_read(link, SCR_CONTROL, &scontrol))) goto out; @@ -4028,9 +4028,17 @@ int sata_link_hardreset(struct ata_link *link, const unsigned long *timing, rc = sata_link_resume(link, timing, deadline); if (rc) goto out; - /* if link is offline nothing more to do */ - if (ata_phys_link_offline(link)) + + if (ata_phys_link_offline(link)) { + if (retry--) { + ata_link_warn(link, + "link still offline after hardreset - retrying\n"); + goto retry; + } + + /* if link is still offline nothing more to do */ goto out; + } /* Link is online. From this point, -ENODEV too is an error. */ if (online) diff --git a/include/linux/libata.h b/include/linux/libata.h index c170be5..2c840c0 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -392,8 +392,10 @@ enum { /* max tries if error condition is still set after ->error_handler */ ATA_EH_MAX_TRIES = 5, - /* sometimes resuming a link requires several retries */ + /* sometimes resuming a link requires several retries... */ ATA_LINK_RESUME_TRIES = 5, + /* ... and sometimes we need to retry the whole reset procedure */ + ATA_LINK_RESET_TRIES = 5, /* how hard are we gonna try to probe/recover devices */ ATA_PROBE_MAX_TRIES = 3,
The sata core driver already retries to resume the link because some controllers ignore writes to the SControl register. We have a use case with the da850 SATA controller where at PLL0 frequency of 456MHz (needed to properly service the LCD controller) the chip becomes unstable and the hardreset operation is ignored the first time 50% of times. Retrying just the resume operation doesn't work - we need to issue the phy/wake reset again to make it work. If ata_phys_link_offline() returns true in sata_link_hardreset(), retry a couple times before really giving up. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- drivers/ata/libata-core.c | 16 ++++++++++++---- include/linux/libata.h | 4 +++- 2 files changed, 15 insertions(+), 5 deletions(-)