From patchwork Tue Nov 16 23:14:03 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 71472 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C5AC7B715A for ; Wed, 17 Nov 2010 10:14:18 +1100 (EST) Received: (qmail 12433 invoked by alias); 16 Nov 2010 23:14:16 -0000 Received: (qmail 12424 invoked by uid 22791); 16 Nov 2010 23:14:15 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, SPF_HELO_PASS, TW_CC, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Nov 2010 23:14:11 +0000 Received: from wpaz13.hot.corp.google.com (wpaz13.hot.corp.google.com [172.24.198.77]) by smtp-out.google.com with ESMTP id oAGNE8ec004840 for ; Tue, 16 Nov 2010 15:14:08 -0800 Received: from pvc30 (pvc30.prod.google.com [10.241.209.158]) by wpaz13.hot.corp.google.com with ESMTP id oAGNE6hI003790 for ; Tue, 16 Nov 2010 15:14:06 -0800 Received: by pvc30 with SMTP id 30so470682pvc.14 for ; Tue, 16 Nov 2010 15:14:06 -0800 (PST) Received: by 10.142.172.13 with SMTP id u13mr6507408wfe.403.1289949246080; Tue, 16 Nov 2010 15:14:06 -0800 (PST) Received: from coign.google.com (dhcp-172-22-124-185.mtv.corp.google.com [172.22.124.185]) by mx.google.com with ESMTPS id p8sm1949025wff.16.2010.11.16.15.14.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 16 Nov 2010 15:14:05 -0800 (PST) From: Ian Lance Taylor To: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: [gccgo] Don't use #ifndef for library names in gospec.c Date: Tue, 16 Nov 2010 15:14:03 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Following a suggestion by Joseph Myers, this patch removes the #ifndef around the library names in gospec.c. If and when we find cases where targets need to define these libraries, they can be added and documented as target macros. Committed to gccgo branch. Ian Index: gospec.c =================================================================== --- gospec.c (revision 166832) +++ gospec.c (working copy) @@ -42,22 +42,12 @@ along with GCC; see the file COPYING3. #define MATH_LIBRARY_PROFILE MATH_LIBRARY #endif -#ifndef THREAD_LIBRARY #define THREAD_LIBRARY "pthread" -#endif -#ifndef THREAD_LIBRARY_PROFILE #define THREAD_LIBRARY_PROFILE THREAD_LIBRARY -#endif -#ifndef LIBGO #define LIBGO "go" -#endif -#ifndef LIBGOBEGIN -#define LIBGOBEGIN "gobegin" -#endif -#ifndef LIBGO_PROFILE #define LIBGO_PROFILE LIBGO -#endif +#define LIBGOBEGIN "gobegin" void lang_specific_driver (struct cl_decoded_option **in_decoded_options,