diff mbox

[U-Boot] imx: nitrogen6x: fix USB host initialization

Message ID 20170112111844.25968-1-gary.bisson@boundarydevices.com
State Accepted
Commit 1c3e62d690a3093d418dac267ae78b0fc0c35274
Delegated to: Stefano Babic
Headers show

Commit Message

Gary Bisson Jan. 12, 2017, 11:18 a.m. UTC
USB Host scanning has been broken since v2016.05.

This is due to all the USB changes that happened between v2016.03
and v2016.05, especially:
2ef117fe4f usb: Remove 200 ms delay in usb_hub_port_connect_change()
a22a264ec3 usb: Change power-on / scanning timeout handling

So we need to increase the init delay to 2s using the usb_pgood_delay
environment variable.

Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
---
 include/configs/nitrogen6x.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stefano Babic Jan. 27, 2017, 9:39 a.m. UTC | #1
On 12/01/2017 12:18, Gary Bisson wrote:
> USB Host scanning has been broken since v2016.05.
> 
> This is due to all the USB changes that happened between v2016.03
> and v2016.05, especially:
> 2ef117fe4f usb: Remove 200 ms delay in usb_hub_port_connect_change()
> a22a264ec3 usb: Change power-on / scanning timeout handling
> 
> So we need to increase the init delay to 2s using the usb_pgood_delay
> environment variable.
> 
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
>  include/configs/nitrogen6x.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
> index c22fed70a4..72ff5c1eab 100644
> --- a/include/configs/nitrogen6x.h
> +++ b/include/configs/nitrogen6x.h
> @@ -137,6 +137,7 @@
>  	"fdt_addr=0x18000000\0" \
>  	"boot_fdt=try\0" \
>  	"ip_dyn=yes\0" \
> +	"usb_pgood_delay=2000\0" \
>  	"mmcdevs=0 1\0" \
>  	"mmcpart=1\0" \
>  	"mmcroot=/dev/mmcblk0p2 rootwait rw\0" \
> @@ -206,6 +207,7 @@
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>  	"bootdevs=" CONFIG_DRIVE_TYPES "\0" \
>  	"umsdevs=" CONFIG_UMSDEVS "\0" \
> +	"usb_pgood_delay=2000\0" \
>  	"console=ttymxc1\0" \
>  	"clearenv=if sf probe || sf probe || sf probe 1 ; then " \
>  		"sf erase 0xc0000 0x2000 && " \
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
index c22fed70a4..72ff5c1eab 100644
--- a/include/configs/nitrogen6x.h
+++ b/include/configs/nitrogen6x.h
@@ -137,6 +137,7 @@ 
 	"fdt_addr=0x18000000\0" \
 	"boot_fdt=try\0" \
 	"ip_dyn=yes\0" \
+	"usb_pgood_delay=2000\0" \
 	"mmcdevs=0 1\0" \
 	"mmcpart=1\0" \
 	"mmcroot=/dev/mmcblk0p2 rootwait rw\0" \
@@ -206,6 +207,7 @@ 
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"bootdevs=" CONFIG_DRIVE_TYPES "\0" \
 	"umsdevs=" CONFIG_UMSDEVS "\0" \
+	"usb_pgood_delay=2000\0" \
 	"console=ttymxc1\0" \
 	"clearenv=if sf probe || sf probe || sf probe 1 ; then " \
 		"sf erase 0xc0000 0x2000 && " \