Patchwork [RFC,v4,17/18] virtagent: qemu-vp, va_send_hello() on startup

login
register
mail settings
Submitter Michael Roth
Date Nov. 16, 2010, 4:01 p.m.
Message ID <1289923320-5638-18-git-send-email-mdroth@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/71431/
State New
Headers show

Comments

Michael Roth - Nov. 16, 2010, 4:01 p.m.
Make the hello call on guest agent startup so QEMU can do whatever init
it needs (currently, capabilities negotiation). Temporarilly commented
due to this tending to induce a virtio bug in RHEL 6.0. As a result
capabilities negotiation must be invoked manually from QEMU via the
agent_capabilities monitor command.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 qemu-vp.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Jes Sorensen - Nov. 18, 2010, 2:22 p.m.
On 11/16/10 17:01, Michael Roth wrote:
> Make the hello call on guest agent startup so QEMU can do whatever init
> it needs (currently, capabilities negotiation). Temporarilly commented
> due to this tending to induce a virtio bug in RHEL 6.0. As a result
> capabilities negotiation must be invoked manually from QEMU via the
> agent_capabilities monitor command.
> 
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
>  qemu-vp.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/qemu-vp.c b/qemu-vp.c
> index 38959e5..b8af513 100644
> --- a/qemu-vp.c
> +++ b/qemu-vp.c
> @@ -580,6 +580,8 @@ int main(int argc, char **argv)
>              errx(EXIT_FAILURE,
>                   "error initializing guest agent");
>          }
> +        /* tell the host the agent is running */
> +        //va_send_hello();

Ehm, not much point adding a call that is commented out :)

Cheers,
Jes

Patch

diff --git a/qemu-vp.c b/qemu-vp.c
index 38959e5..b8af513 100644
--- a/qemu-vp.c
+++ b/qemu-vp.c
@@ -580,6 +580,8 @@  int main(int argc, char **argv)
             errx(EXIT_FAILURE,
                  "error initializing guest agent");
         }
+        /* tell the host the agent is running */
+        //va_send_hello();
     }
 
     /* main i/o loop */