Patchwork [Maverick,SRU] : Acer aspire 7736 - Playback not working

login
register
mail settings
Submitter David Henningsson
Date Nov. 16, 2010, 1:17 p.m.
Message ID <4CE2844E.4000400@canonical.com>
Download mbox | patch
Permalink /patch/71396/
State Rejected
Delegated to: Tim Gardner
Headers show

Comments

David Henningsson - Nov. 16, 2010, 1:17 p.m.
Attaching modified patches according to your wishes.

On 2010-11-11 11:16, David Henningsson wrote:
> BugLink: https://launchpad.net/bugs/617647
>
> SRU Justification:
>
> Impact: A regression in Maverick caused audio playback to stop working
> on Acer aspire 7736.
>
> Fix: Require some new low-impact quirk infrastructure plus the actual
> quirk.
>
> Testcase: Try playing back through internal speakers and headphones on
> the machine.
>
> Both patches has been accepted upstream (as commits 90622917 and
> c3d226ab) but it does not make sense to send to stable@kernel.org since
> 2.6.35 isn't maintained anymore.
>
Stefan Bader - Nov. 16, 2010, 1:22 p.m.
On 11/16/2010 02:17 PM, David Henningsson wrote:
> Attaching modified patches according to your wishes.
> 
Thanks David.

Acked-by: Stefan Bader <stefan.bader@canonical.com>

> On 2010-11-11 11:16, David Henningsson wrote:
>> BugLink: https://launchpad.net/bugs/617647
>>
>> SRU Justification:
>>
>> Impact: A regression in Maverick caused audio playback to stop working
>> on Acer aspire 7736.
>>
>> Fix: Require some new low-impact quirk infrastructure plus the actual
>> quirk.
>>
>> Testcase: Try playing back through internal speakers and headphones on
>> the machine.
>>
>> Both patches has been accepted upstream (as commits 90622917 and
>> c3d226ab) but it does not make sense to send to stable@kernel.org since
>> 2.6.35 isn't maintained anymore.
>>
> 
>
Brad Figg - Nov. 17, 2010, 1:14 a.m.
On 11/16/2010 05:17 AM, David Henningsson wrote:
> Attaching modified patches according to your wishes.
>
> On 2010-11-11 11:16, David Henningsson wrote:
>> BugLink: https://launchpad.net/bugs/617647
>>
>> SRU Justification:
>>
>> Impact: A regression in Maverick caused audio playback to stop working
>> on Acer aspire 7736.
>>
>> Fix: Require some new low-impact quirk infrastructure plus the actual
>> quirk.
>>
>> Testcase: Try playing back through internal speakers and headphones on
>> the machine.
>>
>> Both patches has been accepted upstream (as commits 90622917 and
>> c3d226ab) but it does not make sense to send to stable@kernel.org since
>> 2.6.35 isn't maintained anymore.
>>
>
>

David,

The second patch doesn't apply cleanly against Maverick. Did you apply
it against Maverick and build it?

Brad

Patch

From cebe004745a54b5dec1cdfa2f8ce9708c301941a Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Thu, 14 Oct 2010 15:42:08 +0200
Subject: [PATCH 2/2] ALSA: HDA: Apply SKU override for Acer aspire 7736z

BugLink: http://launchpad.net/bugs/617647

The current SKU value disables playback, so ignore the SKU value.

Committed as c3d226ab8b44fe31e5e6d5739eb353597cea4029 in linux-2.6.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/patch_realtek.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f826bad..1c82c59 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10627,6 +10627,7 @@  static struct alc_config_preset alc882_presets[] = {
 enum {
 	PINFIX_ABIT_AW9D_MAX,
 	PINFIX_PB_M5210,
+	PINFIX_ACER_ASPIRE_7736,
 };
 
 static const struct alc_fixup alc882_fixups[] = {
@@ -10644,11 +10645,15 @@  static const struct alc_fixup alc882_fixups[] = {
 			{}
 		}
 	},
+	[PINFIX_ACER_ASPIRE_7736] = {
+		.sku = ALC_FIXUP_SKU_IGNORE,
+	},
 };
 
 static struct snd_pci_quirk alc882_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1025, 0x0155, "Packard-Bell M5120", PINFIX_PB_M5210),
 	SND_PCI_QUIRK(0x147b, 0x107a, "Abit AW9D-MAX", PINFIX_ABIT_AW9D_MAX),
+	SND_PCI_QUIRK(0x1025, 0x0296, "Acer Aspire 7736z", PINFIX_ACER_ASPIRE_7736),
 	{}
 };
 
-- 
1.7.1