| Message ID | 1289910517-4576-1-git-send-email-bernhard.kohl@nsn.com |
|---|---|
| State | New |
| Headers | show |
On 16.11.2010, at 13:28, Bernhard Kohl wrote: > We have an OS which writes to port 0x400 when probing for special hardware. > This causes an exit of the VM. With SeaBIOS this port isn't used anyway. > > Signed-off-by: Bernhard Kohl <bernhard.kohl@nsn.com> Signed-off-by: Alexander Graf <agraf@suse.de> Alex
On 11/16/2010 01:28 PM, Bernhard Kohl wrote: > We have an OS which writes to port 0x400 when probing for special hardware. > This causes an exit of the VM. With SeaBIOS this port isn't used anyway. > > Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com> > --- > Changes v1 -> v2: > Keep the ports silent. Don't print debug output if DEBUG_BIOS is enabled > which might be confusing. > --- > hw/pc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/pc.c b/hw/pc.c > index 3bf3862..76eabe8 100644 > --- a/hw/pc.c > +++ b/hw/pc.c > @@ -434,8 +434,8 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) > /* Bochs BIOS messages */ > case 0x400: > case 0x401: > - fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val); > - exit(1); > + /* used to be panic, now unused */ > + break; > case 0x402: > case 0x403: > #ifdef DEBUG_BIOS Reviewed-By: Paolo Bonzini <pbonzini@redhat.com> Paolo
On 11/16/2010 06:28 AM, Bernhard Kohl wrote: > We have an OS which writes to port 0x400 when probing for special hardware. > This causes an exit of the VM. With SeaBIOS this port isn't used anyway. > > Signed-off-by: Bernhard Kohl<bernhard.kohl@nsn.com> > Applied. Thanks. Regards, Anthony Liguori > --- > Changes v1 -> v2: > Keep the ports silent. Don't print debug output if DEBUG_BIOS is enabled > which might be confusing. > --- > hw/pc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/pc.c b/hw/pc.c > index 3bf3862..76eabe8 100644 > --- a/hw/pc.c > +++ b/hw/pc.c > @@ -434,8 +434,8 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) > /* Bochs BIOS messages */ > case 0x400: > case 0x401: > - fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val); > - exit(1); > + /* used to be panic, now unused */ > + break; > case 0x402: > case 0x403: > #ifdef DEBUG_BIOS >
diff --git a/hw/pc.c b/hw/pc.c index 3bf3862..76eabe8 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -434,8 +434,8 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val) /* Bochs BIOS messages */ case 0x400: case 0x401: - fprintf(stderr, "BIOS panic at rombios.c, line %d\n", val); - exit(1); + /* used to be panic, now unused */ + break; case 0x402: case 0x403: #ifdef DEBUG_BIOS
We have an OS which writes to port 0x400 when probing for special hardware. This causes an exit of the VM. With SeaBIOS this port isn't used anyway. Signed-off-by: Bernhard Kohl <bernhard.kohl@nsn.com> --- Changes v1 -> v2: Keep the ports silent. Don't print debug output if DEBUG_BIOS is enabled which might be confusing. --- hw/pc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)