diff mbox

[net-next,5/7] tcp_nv: make tcpnv_get_info static

Message ID 20170110181816.18991-6-sthemmin@microsoft.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Stephen Hemminger Jan. 10, 2017, 6:18 p.m. UTC
Function only used in this file.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 net/ipv4/tcp_nv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lawrence Brakmo Jan. 10, 2017, 7:50 p.m. UTC | #1
On 1/10/17, 10:18 AM, "netdev-owner@vger.kernel.org on behalf of Stephen
Hemminger" <netdev-owner@vger.kernel.org on behalf of
stephen@networkplumber.org> wrote:

>Function only used in this file.
>
>Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>---
> net/ipv4/tcp_nv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/net/ipv4/tcp_nv.c b/net/ipv4/tcp_nv.c
>index 5de82a8d4d87..0065f44c40c1 100644
>--- a/net/ipv4/tcp_nv.c
>+++ b/net/ipv4/tcp_nv.c
>@@ -424,8 +424,8 @@ static void tcpnv_acked(struct sock *sk, const struct
>ack_sample *sample)
> }
> 
> /* Extract info for Tcp socket info provided via netlink */
>-size_t tcpnv_get_info(struct sock *sk, u32 ext, int *attr,
>-		      union tcp_cc_info *info)
>+static size_t tcpnv_get_info(struct sock *sk, u32 ext, int *attr,
>+			     union tcp_cc_info *info)
> {
> 	const struct tcpnv *ca = inet_csk_ca(sk);
> 
>-- 
>2.11.0
>

You should also remove the line:
EXPORT_SYMBOL_GPL(tcpnv_get_info);
diff mbox

Patch

diff --git a/net/ipv4/tcp_nv.c b/net/ipv4/tcp_nv.c
index 5de82a8d4d87..0065f44c40c1 100644
--- a/net/ipv4/tcp_nv.c
+++ b/net/ipv4/tcp_nv.c
@@ -424,8 +424,8 @@  static void tcpnv_acked(struct sock *sk, const struct ack_sample *sample)
 }
 
 /* Extract info for Tcp socket info provided via netlink */
-size_t tcpnv_get_info(struct sock *sk, u32 ext, int *attr,
-		      union tcp_cc_info *info)
+static size_t tcpnv_get_info(struct sock *sk, u32 ext, int *attr,
+			     union tcp_cc_info *info)
 {
 	const struct tcpnv *ca = inet_csk_ca(sk);