| Message ID | 1484070109-105991-1-git-send-email-kafai@fb.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Jan 10, 2017 at 7:41 PM, Martin KaFai Lau <kafai@fb.com> wrote: > In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"), > it changed EOPNOTSUPP to ENOTSUPP by mistake. This patch fixes it. > > Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs") > Signed-off-by: Martin KaFai Lau <kafai@fb.com> Acked-by: Saeed Mahameed <saeedm@mellanox.com> Thank you martin. Small question though, is it essential for the upper layer to get the correct errno ? or this is just a cleanup ?
On Tue, Jan 10, 2017 at 10:04:55PM +0200, Saeed Mahameed wrote: > On Tue, Jan 10, 2017 at 7:41 PM, Martin KaFai Lau <kafai@fb.com> wrote: > > In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"), > > it changed EOPNOTSUPP to ENOTSUPP by mistake. This patch fixes it. > > > > Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs") > > Signed-off-by: Martin KaFai Lau <kafai@fb.com> > > Acked-by: Saeed Mahameed <saeedm@mellanox.com> > > > Thank you martin. > > Small question though, > is it essential for the upper layer to get the correct errno ? or this > is just a cleanup ? Former. probably for the netlink's NLMSG_ERROR also.
From: Martin KaFai Lau <kafai@fb.com> Date: Tue, 10 Jan 2017 09:41:49 -0800 > In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"), > it changed EOPNOTSUPP to ENOTSUPP by mistake. This patch fixes it. > > Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs") > Signed-off-by: Martin KaFai Lau <kafai@fb.com> Applied.
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index edbe200ac2fa..4910d9af1933 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c @@ -2277,7 +2277,7 @@ static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu) if (priv->tx_ring_num[TX_XDP] && !mlx4_en_check_xdp_mtu(dev, new_mtu)) - return -ENOTSUPP; + return -EOPNOTSUPP; dev->mtu = new_mtu;
In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"), it changed EOPNOTSUPP to ENOTSUPP by mistake. This patch fixes it. Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs") Signed-off-by: Martin KaFai Lau <kafai@fb.com> --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)