diff mbox

[U-Boot] xilinx_phy: Pass correct pointer to fdtdec_get_int()

Message ID 8b6a01451ed33c99514d0b1c1e686523caf2351d.1484051718.git.michal.simek@xilinx.com
State Accepted
Commit 1e946297575b320e6f6ab8a33467df17d8e38923
Delegated to: Michal Simek
Headers show

Commit Message

Michal Simek Jan. 10, 2017, 12:35 p.m. UTC 
From: Kamensky Ivan <kamensky.ivan@mail.ru>

This patch fixes incorrect pointer on offset device in device tree blob.
When using with the component "Ethernet 1G/2.5G BASE-X PCS/PMA or SGMII"
it does not understand what type is XAE_PHY_TYPE_1000BASE_X and trying
to change frequency.

Signed-off-by: Kamensky Ivan <kamensky.ivan@mail.ru>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/net/phy/xilinx_phy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Joe Hershberger Jan. 10, 2017, 7:55 p.m. UTC | #1 
On Tue, Jan 10, 2017 at 6:35 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> From: Kamensky Ivan <kamensky.ivan@mail.ru>
>
> This patch fixes incorrect pointer on offset device in device tree blob.
> When using with the component "Ethernet 1G/2.5G BASE-X PCS/PMA or SGMII"
> it does not understand what type is XAE_PHY_TYPE_1000BASE_X and trying
> to change frequency.
>
> Signed-off-by: Kamensky Ivan <kamensky.ivan@mail.ru>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
diff mbox

Patch

diff --git a/drivers/net/phy/xilinx_phy.c b/drivers/net/phy/xilinx_phy.c
index f3eaf2e97ced..920bfcb380b3 100644
--- a/drivers/net/phy/xilinx_phy.c
+++ b/drivers/net/phy/xilinx_phy.c
@@ -101,11 +101,11 @@  static int xilinxphy_startup(struct phy_device *phydev)
 
 static int xilinxphy_of_init(struct phy_device *phydev)
 {
-	struct udevice *dev = (struct udevice *)&phydev->dev;
 	u32 phytype;
 
 	debug("%s\n", __func__);
-	phytype = fdtdec_get_int(gd->fdt_blob, dev->of_offset, "phy-type", -1);
+	phytype = fdtdec_get_int(gd->fdt_blob, phydev->dev->of_offset,
+				 "phy-type", -1);
 	if (phytype == XAE_PHY_TYPE_1000BASE_X)
 		phydev->flags |= XAE_PHY_TYPE_1000BASE_X;