From patchwork Tue Nov 16 00:02:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kukjin Kim X-Patchwork-Id: 71318 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-fx0-f56.google.com (mail-fx0-f56.google.com [209.85.161.56]) by ozlabs.org (Postfix) with ESMTP id 25BE7B7135 for ; Tue, 16 Nov 2010 11:14:39 +1100 (EST) Received: by fxm13 with SMTP id 13sf13916fxm.11 for ; Mon, 15 Nov 2010 16:14:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:mime-version:x-beenthere:received :received:received:received:received-spf:received:received:from:to :cc:subject:date:message-id:x-mailer:in-reply-to:references :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type; bh=V/VW4qptdUXjQN9AhOko5shduWKrpQEIOLZA4cSufvg=; b=CNFnE4Eckc0lDouDtsdMiuUl33+UikBNjNaj7i17ex/PNW87s3Rv5xj29RFtaWavvK 8rndF/SJw+GYS+YOKgvCN/nXQcQE9Z8rmNRt+zVqLRwnhRPJ1Cg46zP0/5sr5w5oT5wV xDrO9Z9GSFuLPqum3P7UW6FIyqnKh0FvChUgk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=mime-version:x-beenthere:received-spf:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; b=A73llNcj3m3YmD+4UmmwtmP9oXyPFRqR0CiczwALeOXG2rLaPZ3nE0wXiu/dzvp+Lg lQLrIjhd2H3RuIeNNKjTbw2Qh4rQhJrT/iez5+s0qYWdwddVpS6eZnEuWLNSM/AuPlSC 1bVXDudUiLYpjxYuXSqDBA/TZ+UpCH/ZTYjXs= Received: by 10.223.85.204 with SMTP id p12mr366270fal.3.1289866477370; Mon, 15 Nov 2010 16:14:37 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.223.145.130 with SMTP id d2ls1253684fav.1.p; Mon, 15 Nov 2010 16:14:36 -0800 (PST) Received: by 10.223.83.10 with SMTP id d10mr539413fal.23.1289866476391; Mon, 15 Nov 2010 16:14:36 -0800 (PST) Received: by 10.223.83.10 with SMTP id d10mr539412fal.23.1289866476379; Mon, 15 Nov 2010 16:14:36 -0800 (PST) Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) by gmr-mx.google.com with ESMTP id 9si335013fax.13.2010.11.15.16.14.36; Mon, 15 Nov 2010 16:14:36 -0800 (PST) Received-SPF: neutral (google.com: 213.95.27.120 is neither permitted nor denied by best guess record for domain of kgene.kim@samsung.com) client-ip=213.95.27.120; Received: from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.69) (envelope-from ) id 1PI9Bw-0008VN-7R; Tue, 16 Nov 2010 01:14:32 +0100 Received: from [12.23.102.184] (helo=localhost.localdomain) by jackpot.kr.gnumonks.org with esmtp (Exim 4.69) (envelope-from ) id 1PI8II-0003GC-2o; Tue, 16 Nov 2010 08:17:02 +0900 From: Kukjin Kim To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com Cc: ben-linux@fluff.org, p_gortmaker@yahoo.com, a.zummo@towertech.it, Kukjin Kim , Wan ZongShun Subject: [rtc-linux] [PATCH 2/3] rtc: rtc-s3c: Add spin_lock_irq in s3c_rtc_setaie Date: Tue, 16 Nov 2010 09:02:53 +0900 Message-Id: <1289865774-31073-3-git-send-email-kgene.kim@samsung.com> X-Mailer: git-send-email 1.6.2.5 In-Reply-To: <1289865774-31073-1-git-send-email-kgene.kim@samsung.com> References: <1289865774-31073-1-git-send-email-kgene.kim@samsung.com> X-Original-Sender: kgene.kim@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 213.95.27.120 is neither permitted nor denied by best guess record for domain of kgene.kim@samsung.com) smtp.mail=kgene.kim@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , This patch adds spin_lock_irq() and spin_unlock_irq() during alarm interrupt configuration to avoid interrupt missing. Cc: Ben Dooks Cc: Wan ZongShun Cc: Alessandro Zummo Signed-off-by: Kukjin Kim --- drivers/rtc/rtc-s3c.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index e2636ff..bb88027 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -82,12 +82,14 @@ static int s3c_rtc_setaie(struct device *dev, unsigned int enabled) pr_debug("%s: aie=%d\n", __func__, enabled); + spin_lock_irq(&s3c_rtc_pie_lock); tmp = readb(s3c_rtc_base + S3C2410_RTCALM) & ~S3C2410_RTCALM_ALMEN; if (enabled) tmp |= S3C2410_RTCALM_ALMEN; writeb(tmp, s3c_rtc_base + S3C2410_RTCALM); + spin_unlock_irq(&s3c_rtc_pie_lock); return 0; }