From patchwork Mon Nov 15 20:44:35 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 71317 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4211AB6EE9 for ; Tue, 16 Nov 2010 11:12:40 +1100 (EST) Received: from localhost ([127.0.0.1]:52782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI9A5-00046p-7V for incoming@patchwork.ozlabs.org; Mon, 15 Nov 2010 19:12:37 -0500 Received: from [140.186.70.92] (port=52483 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI99b-00046c-5P for qemu-devel@nongnu.org; Mon, 15 Nov 2010 19:12:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PI99a-0006HJ-4p for qemu-devel@nongnu.org; Mon, 15 Nov 2010 19:12:07 -0500 Received: from mtagate4.uk.ibm.com ([194.196.100.164]:52491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PI99Z-0006H0-Mt for qemu-devel@nongnu.org; Mon, 15 Nov 2010 19:12:06 -0500 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate4.uk.ibm.com (8.13.1/8.13.1) with ESMTP id oAFKip17030346 for ; Mon, 15 Nov 2010 20:44:51 GMT Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oAFKis5K3350754 for ; Mon, 15 Nov 2010 20:44:54 GMT Received: from d06av10.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oAFKip1x011502 for ; Mon, 15 Nov 2010 13:44:51 -0700 Received: from stefan-thinkpad.ibm.com (sig-9-145-201-127.de.ibm.com [9.145.201.127]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id oAFKioxf011488; Mon, 15 Nov 2010 13:44:51 -0700 From: Stefan Hajnoczi To: Date: Mon, 15 Nov 2010 20:44:35 +0000 Message-Id: <1289853878-15188-2-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1289853878-15188-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1289853878-15188-1-git-send-email-stefanha@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 1/4] virtio-blk: Convert fprintf() to error_report() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors should be logged using error_report() so they go to the appropriate monitor. Signed-off-by: Stefan Hajnoczi --- hw/virtio-blk.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 49528a9..e5f9b27 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -324,13 +324,13 @@ static void virtio_blk_handle_request(VirtIOBlockReq *req, MultiReqBuffer *mrb) { if (req->elem.out_num < 1 || req->elem.in_num < 1) { - fprintf(stderr, "virtio-blk missing headers\n"); + error_report("virtio-blk missing headers"); exit(1); } if (req->elem.out_sg[0].iov_len < sizeof(*req->out) || req->elem.in_sg[req->elem.in_num - 1].iov_len < sizeof(*req->in)) { - fprintf(stderr, "virtio-blk header not in correct element\n"); + error_report("virtio-blk header not in correct element"); exit(1); }