| Message ID | 1484000039-671014-1-git-send-email-kafai@fb.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello! On 01/10/2017 01:13 AM, Martin KaFai Lau wrote: > In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"), > it changed ENOTSUPP to EOPNOTSUPP by mistake. This patch fixes it. You mean vice versa (looking at your patch)? > Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs") > Signed-off-by: Martin KaFai Lau <kafai@fb.com> > --- > drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c > index edbe200ac2fa..4910d9af1933 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c > +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c > @@ -2277,7 +2277,7 @@ static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu) > > if (priv->tx_ring_num[TX_XDP] && > !mlx4_en_check_xdp_mtu(dev, new_mtu)) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > > dev->mtu = new_mtu; > MBR, Sergei
On Tue, Jan 10, 2017 at 03:43:39PM +0300, Sergei Shtylyov wrote: > Hello! > > On 01/10/2017 01:13 AM, Martin KaFai Lau wrote: > > >In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"), > >it changed ENOTSUPP to EOPNOTSUPP by mistake. This patch fixes it. > > You mean vice versa (looking at your patch)? Indeed. Will send v2 to correct this. > > >Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs") > >Signed-off-by: Martin KaFai Lau <kafai@fb.com> > >--- > > drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c > >index edbe200ac2fa..4910d9af1933 100644 > >--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c > >+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c > >@@ -2277,7 +2277,7 @@ static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu) > > > > if (priv->tx_ring_num[TX_XDP] && > > !mlx4_en_check_xdp_mtu(dev, new_mtu)) > >- return -ENOTSUPP; > >+ return -EOPNOTSUPP; > > > > dev->mtu = new_mtu; > > > > MBR, Sergei >
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index edbe200ac2fa..4910d9af1933 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c @@ -2277,7 +2277,7 @@ static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu) if (priv->tx_ring_num[TX_XDP] && !mlx4_en_check_xdp_mtu(dev, new_mtu)) - return -ENOTSUPP; + return -EOPNOTSUPP; dev->mtu = new_mtu;
In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"), it changed ENOTSUPP to EOPNOTSUPP by mistake. This patch fixes it. Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs") Signed-off-by: Martin KaFai Lau <kafai@fb.com> --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)