Patchwork Support official CLooG.org versions.

login
register
mail settings
Submitter Andreas Schwab
Date Nov. 15, 2010, 4:22 p.m.
Message ID <m31v6m8slk.fsf@redhat.com>
Download mbox | patch
Permalink /patch/71238/
State New
Headers show

Comments

Andreas Schwab - Nov. 15, 2010, 4:22 p.m.
Paolo Bonzini <bonzini@gnu.org> writes:

> On 11/15/2010 04:38 PM, Andreas Schwab wrote:
>>> >  +  AC_ARG_WITH(cloog_include,
>> The option is called --with-cloog-include, not --with-cloog_include.
>>
>>> >  +  AC_ARG_WITH(cloog_lib,
>> Likewise.
>
> I noticed the same, but since it doesn't matter (either works) and
> other AC_ARG_WITH invocations are using underscores,

2010-11-15  Andreas Schwab  <schwab@redhat.com>

	* configure.ac: Fix spelling in option names.
	* configure: Regenerated.

config/:
	* cloog.m4 (CLOOG_INIT_FLAGS): Fix spelling in option names.
Paolo Bonzini - Nov. 15, 2010, 4:23 p.m.
On 11/15/2010 05:22 PM, Andreas Schwab wrote:
> Paolo Bonzini<bonzini@gnu.org>  writes:
>
>> On 11/15/2010 04:38 PM, Andreas Schwab wrote:
>>>>>   +  AC_ARG_WITH(cloog_include,
>>> The option is called --with-cloog-include, not --with-cloog_include.
>>>
>>>>>   +  AC_ARG_WITH(cloog_lib,
>>> Likewise.
>>
>> I noticed the same, but since it doesn't matter (either works) and
>> other AC_ARG_WITH invocations are using underscores,
>
> 2010-11-15  Andreas Schwab<schwab@redhat.com>
>
> 	* configure.ac: Fix spelling in option names.
> 	* configure: Regenerated.
>
> config/:
> 	* cloog.m4 (CLOOG_INIT_FLAGS): Fix spelling in option names.
>
>
> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 166757)
> +++ configure.ac	(working copy)
> @@ -1273,9 +1273,9 @@
>   AC_ARG_WITH(mpc, [  --with-mpc=PATH        specify prefix directory for installed MPC package.
>                             Equivalent to --with-mpc-include=PATH/include
>                             plus --with-mpc-lib=PATH/lib])
> -AC_ARG_WITH(mpc_include, [  --with-mpc-include=PATH
> +AC_ARG_WITH(mpc-include, [  --with-mpc-include=PATH
>                             specify directory for installed MPC include files])
> -AC_ARG_WITH(mpc_lib, [  --with-mpc-lib=PATH    specify directory for the installed MPC library])
> +AC_ARG_WITH(mpc-lib, [  --with-mpc-lib=PATH    specify directory for the installed MPC library])
>
>   if test "x$with_mpc" != x; then
>     gmplibs="-L$with_mpc/lib $gmplibs"
> @@ -1306,9 +1306,9 @@
>   AC_ARG_WITH(mpfr, [  --with-mpfr=PATH        specify prefix directory for installed MPFR package.
>                             Equivalent to --with-mpfr-include=PATH/include
>                             plus --with-mpfr-lib=PATH/lib])
> -AC_ARG_WITH(mpfr_include, [  --with-mpfr-include=PATH
> +AC_ARG_WITH(mpfr-include, [  --with-mpfr-include=PATH
>                             specify directory for installed MPFR include files])
> -AC_ARG_WITH(mpfr_lib, [  --with-mpfr-lib=PATH    specify directory for the installed MPFR library])
> +AC_ARG_WITH(mpfr-lib, [  --with-mpfr-lib=PATH    specify directory for the installed MPFR library])
>
>   if test "x$with_mpfr" != x; then
>     gmplibs="-L$with_mpfr/lib $gmplibs"
> @@ -1339,8 +1339,8 @@
>   AC_ARG_WITH(gmp, [  --with-gmp=PATH         specify prefix directory for the installed GMP package.
>                             Equivalent to --with-gmp-include=PATH/include
>                             plus --with-gmp-lib=PATH/lib])
> -AC_ARG_WITH(gmp_include, [  --with-gmp-include=PATH specify directory for installed GMP include files])
> -AC_ARG_WITH(gmp_lib, [  --with-gmp-lib=PATH     specify directory for the installed GMP library])
> +AC_ARG_WITH(gmp-include, [  --with-gmp-include=PATH specify directory for installed GMP include files])
> +AC_ARG_WITH(gmp-lib, [  --with-gmp-lib=PATH     specify directory for the installed GMP library])
>
>
>   if test "x$with_gmp" != x; then
> @@ -1539,8 +1539,8 @@
>   AC_ARG_WITH(ppl, [  --with-ppl=PATH         Specify prefix directory for the installed PPL package
>                             Equivalent to --with-ppl-include=PATH/include
>                             plus --with-ppl-lib=PATH/lib])
> -AC_ARG_WITH(ppl_include, [  --with-ppl-include=PATH Specify directory for installed PPL include files])
> -AC_ARG_WITH(ppl_lib, [  --with-ppl-lib=PATH     Specify the directory for the installed PPL library])
> +AC_ARG_WITH(ppl-include, [  --with-ppl-include=PATH Specify directory for installed PPL include files])
> +AC_ARG_WITH(ppl-lib, [  --with-ppl-lib=PATH     Specify the directory for the installed PPL library])
>
>   case $with_ppl in
>     no)
> Index: config/cloog.m4
> ===================================================================
> --- config/cloog.m4	(revision 166757)
> +++ config/cloog.m4	(working copy)
> @@ -28,11 +28,11 @@
>         [Specify prefix directory for the installed CLooG-PPL package.
>          Equivalent to --with-cloog-include=PATH/include
>          plus --with-cloog-lib=PATH/lib])])
> -  AC_ARG_WITH(cloog_include,
> +  AC_ARG_WITH([cloog-include],
>       [AS_HELP_STRING(
>         [--with-cloog-include=PATH],
>         [Specify directory for installed CLooG include files])])
> -  AC_ARG_WITH(cloog_lib,
> +  AC_ARG_WITH([cloog-lib],
>       [AS_HELP_STRING(
>         [--with-cloog-lib=PATH],
>         [Specify the directory for the installed CLooG library])])
>

OK

Paolo

Patch

Index: configure.ac
===================================================================
--- configure.ac	(revision 166757)
+++ configure.ac	(working copy)
@@ -1273,9 +1273,9 @@ 
 AC_ARG_WITH(mpc, [  --with-mpc=PATH        specify prefix directory for installed MPC package.
                           Equivalent to --with-mpc-include=PATH/include
                           plus --with-mpc-lib=PATH/lib])
-AC_ARG_WITH(mpc_include, [  --with-mpc-include=PATH
+AC_ARG_WITH(mpc-include, [  --with-mpc-include=PATH
                           specify directory for installed MPC include files])
-AC_ARG_WITH(mpc_lib, [  --with-mpc-lib=PATH    specify directory for the installed MPC library])
+AC_ARG_WITH(mpc-lib, [  --with-mpc-lib=PATH    specify directory for the installed MPC library])
 
 if test "x$with_mpc" != x; then
   gmplibs="-L$with_mpc/lib $gmplibs"
@@ -1306,9 +1306,9 @@ 
 AC_ARG_WITH(mpfr, [  --with-mpfr=PATH        specify prefix directory for installed MPFR package.
                           Equivalent to --with-mpfr-include=PATH/include
                           plus --with-mpfr-lib=PATH/lib])
-AC_ARG_WITH(mpfr_include, [  --with-mpfr-include=PATH
+AC_ARG_WITH(mpfr-include, [  --with-mpfr-include=PATH
                           specify directory for installed MPFR include files])
-AC_ARG_WITH(mpfr_lib, [  --with-mpfr-lib=PATH    specify directory for the installed MPFR library])
+AC_ARG_WITH(mpfr-lib, [  --with-mpfr-lib=PATH    specify directory for the installed MPFR library])
 
 if test "x$with_mpfr" != x; then
   gmplibs="-L$with_mpfr/lib $gmplibs"
@@ -1339,8 +1339,8 @@ 
 AC_ARG_WITH(gmp, [  --with-gmp=PATH         specify prefix directory for the installed GMP package.
                           Equivalent to --with-gmp-include=PATH/include
                           plus --with-gmp-lib=PATH/lib])
-AC_ARG_WITH(gmp_include, [  --with-gmp-include=PATH specify directory for installed GMP include files])
-AC_ARG_WITH(gmp_lib, [  --with-gmp-lib=PATH     specify directory for the installed GMP library])
+AC_ARG_WITH(gmp-include, [  --with-gmp-include=PATH specify directory for installed GMP include files])
+AC_ARG_WITH(gmp-lib, [  --with-gmp-lib=PATH     specify directory for the installed GMP library])
 
 
 if test "x$with_gmp" != x; then
@@ -1539,8 +1539,8 @@ 
 AC_ARG_WITH(ppl, [  --with-ppl=PATH         Specify prefix directory for the installed PPL package
                           Equivalent to --with-ppl-include=PATH/include
                           plus --with-ppl-lib=PATH/lib])
-AC_ARG_WITH(ppl_include, [  --with-ppl-include=PATH Specify directory for installed PPL include files])
-AC_ARG_WITH(ppl_lib, [  --with-ppl-lib=PATH     Specify the directory for the installed PPL library])
+AC_ARG_WITH(ppl-include, [  --with-ppl-include=PATH Specify directory for installed PPL include files])
+AC_ARG_WITH(ppl-lib, [  --with-ppl-lib=PATH     Specify the directory for the installed PPL library])
 
 case $with_ppl in 
   no)
Index: config/cloog.m4
===================================================================
--- config/cloog.m4	(revision 166757)
+++ config/cloog.m4	(working copy)
@@ -28,11 +28,11 @@ 
       [Specify prefix directory for the installed CLooG-PPL package.
        Equivalent to --with-cloog-include=PATH/include
        plus --with-cloog-lib=PATH/lib])])
-  AC_ARG_WITH(cloog_include,
+  AC_ARG_WITH([cloog-include],
     [AS_HELP_STRING(
       [--with-cloog-include=PATH],
       [Specify directory for installed CLooG include files])])
-  AC_ARG_WITH(cloog_lib,
+  AC_ARG_WITH([cloog-lib],
     [AS_HELP_STRING(
       [--with-cloog-lib=PATH],
       [Specify the directory for the installed CLooG library])])