Message ID | 1483780711-5759-1-git-send-email-cugyly@163.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: yuan linyu <cugyly@163.com> Date: Sat, 7 Jan 2017 17:18:31 +0800 > From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn> > > sock_init() call it but not check it's return value, > so change it to void return and add an internal BUG_ON() check. > > Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn> Applied.
diff --git a/net/socket.c b/net/socket.c index c65bb92..3ef02e9 100644 --- a/net/socket.c +++ b/net/socket.c @@ -287,7 +287,7 @@ static void init_once(void *foo) inode_init_once(&ei->vfs_inode); } -static int init_inodecache(void) +static void init_inodecache(void) { sock_inode_cachep = kmem_cache_create("sock_inode_cache", sizeof(struct socket_alloc), @@ -296,9 +296,7 @@ static int init_inodecache(void) SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD | SLAB_ACCOUNT), init_once); - if (sock_inode_cachep == NULL) - return -ENOMEM; - return 0; + BUG_ON(sock_inode_cachep == NULL); } static const struct super_operations sockfs_ops = {