| Message ID | 20170106193210.7896-1-aserdean@cloudbasesolutions.com |
|---|---|
| State | Superseded |
| Headers | show |
Acked-by: Sairam Venugopal <vsairam@vmware.com> On 1/6/17, 11:33 AM, "ovs-dev-bounces@openvswitch.org on behalf of Alin Serdean" <ovs-dev-bounces@openvswitch.org on behalf of aserdean@cloudbasesolutions.com> wrote: >bufferStart can be used directly to access the data of the net buffer. >Add the MDL offset to save unnecessary additions. > >Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> >--- >v2: no change >--- > datapath-windows/ovsext/Actions.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c >index 2a24410..bf4f25c 100644 >--- a/datapath-windows/ovsext/Actions.c >+++ b/datapath-windows/ovsext/Actions.c >@@ -1390,13 +1390,13 @@ OvsUpdateIPv4Header(OvsForwardingContext *ovsFwdCtx, > mdlLen -= curMdlOffset; > ASSERT(mdlLen >= hdrSize); > } >- >- ipHdr = (IPHdr *)(bufferStart + curMdlOffset + layers->l3Offset); >+ bufferStart += curMdlOffset; >+ ipHdr = (IPHdr *)(bufferStart + layers->l3Offset); > > if (layers->isTcp) { >- tcpHdr = (TCPHdr *)(bufferStart + curMdlOffset + layers->l4Offset); >+ tcpHdr = (TCPHdr *)(bufferStart + layers->l4Offset); > } else if (layers->isUdp) { >- udpHdr = (UDPHdr *)(bufferStart + curMdlOffset + layers->l4Offset); >+ udpHdr = (UDPHdr *)(bufferStart + layers->l4Offset); > } > > /* >-- >2.10.2.windows.1 >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DgICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=iwmud2mUovzcxo_0gkX6JE9b8wRLXIB2wniV4NFGc0o&s=fNkt0XmwLrxcFVHCeAV1rxtivIHNd1g3SXSBAUuP_do&e=
diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c index 2a24410..bf4f25c 100644 --- a/datapath-windows/ovsext/Actions.c +++ b/datapath-windows/ovsext/Actions.c @@ -1390,13 +1390,13 @@ OvsUpdateIPv4Header(OvsForwardingContext *ovsFwdCtx, mdlLen -= curMdlOffset; ASSERT(mdlLen >= hdrSize); } - - ipHdr = (IPHdr *)(bufferStart + curMdlOffset + layers->l3Offset); + bufferStart += curMdlOffset; + ipHdr = (IPHdr *)(bufferStart + layers->l3Offset); if (layers->isTcp) { - tcpHdr = (TCPHdr *)(bufferStart + curMdlOffset + layers->l4Offset); + tcpHdr = (TCPHdr *)(bufferStart + layers->l4Offset); } else if (layers->isUdp) { - udpHdr = (UDPHdr *)(bufferStart + curMdlOffset + layers->l4Offset); + udpHdr = (UDPHdr *)(bufferStart + layers->l4Offset); } /*
bufferStart can be used directly to access the data of the net buffer. Add the MDL offset to save unnecessary additions. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> --- v2: no change --- datapath-windows/ovsext/Actions.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)