Patchwork Fix typo of the comment in resource.h

login
register
mail settings
Submitter Mingjie Xing
Date Nov. 15, 2010, 6:18 a.m.
Message ID <AANLkTimtJB1NWvMMDBcsAx=ybNky2QL23SkO+A-4o4+d@mail.gmail.com>
Download mbox | patch
Permalink /patch/71179/
State New
Headers show

Comments

Mingjie Xing - Nov. 15, 2010, 6:18 a.m.
2010/11/15 Dave Korn <dave.korn.cygwin@gmail.com>:
> On 15/11/2010 05:11, Mingjie Xing wrote:
>> Hi
>>
>> This small patch fix the typo of the comment in resource.h. Is it OK?
>
>  I cannot approve the patch, but spotted an additional grammar problem that
> you could fix at the same time:
>
> -  char unch_memory;    /* Insn sets of needs a "unchanging" MEM.  */
> +  char unch_memory;    /* Insn sets or needs a "unchanging" MEM.  */
>
>  It should be 'an "unchanging" ...', not 'a "unchanging" ...'.
>
>    cheers,
>      DaveK
>

Indeed. Updated the patch. Thanks.

Mingjie,
Mingjie Xing - Nov. 18, 2010, 1:21 a.m.
2010/11/15 Mingjie Xing <mingjie.xing@gmail.com>:
> 2010/11/15 Dave Korn <dave.korn.cygwin@gmail.com>:
>> On 15/11/2010 05:11, Mingjie Xing wrote:
>>> Hi
>>>
>>> This small patch fix the typo of the comment in resource.h. Is it OK?
>>
>>  I cannot approve the patch, but spotted an additional grammar problem that
>> you could fix at the same time:
>>
>> -  char unch_memory;    /* Insn sets of needs a "unchanging" MEM.  */
>> +  char unch_memory;    /* Insn sets or needs a "unchanging" MEM.  */
>>
>>  It should be 'an "unchanging" ...', not 'a "unchanging" ...'.
>>
>>    cheers,
>>      DaveK
>>
>
> Indeed. Updated the patch. Thanks.
>
> Mingjie,
>
> Index: resource.h
> ===================================================================
> --- resource.h  (revision 163986)
> +++ resource.h  (working copy)
> @@ -33,7 +33,7 @@ along with GCC; see the file COPYING3.
>  struct resources
>  {
>   char memory;         /* Insn sets or needs a memory location.  */
> -  char unch_memory;    /* Insn sets of needs a "unchanging" MEM.  */
> +  char unch_memory;    /* Insn sets or needs an "unchanging" MEM.  */
>   char volatil;                /* Insn sets or needs a volatile memory loc.  */
>   char cc;             /* Insn sets or needs the condition codes.  */
>   HARD_REG_SET regs;   /* Which registers are set or needed.  */
>

Is it OK? Really simple changes. :-)

Thanks
Mingjie
Dave Korn - Nov. 18, 2010, 2:15 a.m.
On 18/11/2010 01:21, Mingjie Xing wrote:

> Is it OK? Really simple changes. :-)

  I'm sure it will be, but please be patient; we have very serious shortage of
manpower.  The tradition is that we usually wait 10-14 days before sending a
ping, and even then sometimes it takes several pings.

    cheers,
      DaveK
Paolo Bonzini - Nov. 18, 2010, 9:44 p.m.
On 11/18/2010 03:15 AM, Dave Korn wrote:
> On 18/11/2010 01:21, Mingjie Xing wrote:
>
>> Is it OK? Really simple changes. :-)
>
>    I'm sure it will be, but please be patient; we have very serious shortage of
> manpower.  The tradition is that we usually wait 10-14 days before sending a
> ping, and even then sometimes it takes several pings.

Go ahead, do you have commit access?

Paolo
Mingjie Xing - Nov. 19, 2010, 1:53 a.m.
2010/11/19 Paolo Bonzini <bonzini@gnu.org>:
> On 11/18/2010 03:15 AM, Dave Korn wrote:
>>
>> On 18/11/2010 01:21, Mingjie Xing wrote:
>>
>>> Is it OK? Really simple changes. :-)
>>
>>   I'm sure it will be, but please be patient; we have very serious
>> shortage of
>> manpower.  The tradition is that we usually wait 10-14 days before sending
>> a
>> ping, and even then sometimes it takes several pings.
>
> Go ahead, do you have commit access?
>
> Paolo
>

Committed revision 166927.

Thanks,
Mingjie

Patch

Index: resource.h
===================================================================
--- resource.h  (revision 163986)
+++ resource.h  (working copy)
@@ -33,7 +33,7 @@  along with GCC; see the file COPYING3.
 struct resources
 {
   char memory;         /* Insn sets or needs a memory location.  */
-  char unch_memory;    /* Insn sets of needs a "unchanging" MEM.  */
+  char unch_memory;    /* Insn sets or needs an "unchanging" MEM.  */
   char volatil;                /* Insn sets or needs a volatile memory loc.  */
   char cc;             /* Insn sets or needs the condition codes.  */
   HARD_REG_SET regs;   /* Which registers are set or needed.  */