| Message ID | 20170106074548.9558-1-joerg.krause@embedded.rocks |
|---|---|
| State | Superseded |
| Headers | show |
Hi Jörg, On Fri, Jan 06, 2017 at 08:45:48AM +0100, Jörg Krause wrote: > The version 0.20 of mpd uses C++14 language features and therefor > requires at least GCC version 4.9. > > Fixes: > http://autobuild.buildroot.net/results/3fe/3fe440c0b9d05acb44553a8f02f688570e06bca9/ > http://autobuild.buildroot.net/results/d33/d3309bea9411fca70d61d07c36f58718bc87e6d1/ > http://autobuild.buildroot.net/results/208/208bb987f52b8ba65e3c6fc9b6e917dbd44c0fbd/ > http://autobuild.buildroot.net/results/9b9/9b9659ba30afde49912276fe7f9c282953a352ab/ > .. and more. > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> This is identical to http://patchwork.ozlabs.org/patch/711567/. baruch > --- > package/mpd/Config.in | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/package/mpd/Config.in b/package/mpd/Config.in > index 82bbd8d21..e0bb60447 100644 > --- a/package/mpd/Config.in > +++ b/package/mpd/Config.in > @@ -4,7 +4,7 @@ menuconfig BR2_PACKAGE_MPD > depends on BR2_USE_WCHAR # libglib2, flac > depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 > depends on BR2_USE_MMU # libglib2 > - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6 > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14 > depends on BR2_TOOLCHAIN_HAS_ATOMIC > select BR2_PACKAGE_BOOST > select BR2_PACKAGE_LIBGLIB2 > @@ -315,8 +315,8 @@ config BR2_PACKAGE_MPD_UPNP > > endif > > -comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.6" > +comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.9" > depends on BR2_USE_MMU > depends on BR2_TOOLCHAIN_HAS_ATOMIC > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ > - !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_6 > + !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
On Fri, 2017-01-06 at 12:44 +0200, Baruch Siach wrote: > Hi Jörg, > > On Fri, Jan 06, 2017 at 08:45:48AM +0100, Jörg Krause wrote: > > The version 0.20 of mpd uses C++14 language features and therefor > > requires at least GCC version 4.9. > > > > Fixes: > > http://autobuild.buildroot.net/results/3fe/3fe440c0b9d05acb44553a8f > > 02f688570e06bca9/ > > http://autobuild.buildroot.net/results/d33/d3309bea9411fca70d61d07c > > 36f58718bc87e6d1/ > > http://autobuild.buildroot.net/results/208/208bb987f52b8ba65e3c6fc9 > > b6e917dbd44c0fbd/ > > http://autobuild.buildroot.net/results/9b9/9b9659ba30afde49912276fe > > 7f9c282953a352ab/ > > .. and more. > > > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > > This is identical to http://patchwork.ozlabs.org/patch/711567/. > Looks like our patches overlaped by a few minutes. I'll remove my patch from patchwork. Jörg > > > --- > > package/mpd/Config.in | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/package/mpd/Config.in b/package/mpd/Config.in > > index 82bbd8d21..e0bb60447 100644 > > --- a/package/mpd/Config.in > > +++ b/package/mpd/Config.in > > @@ -4,7 +4,7 @@ menuconfig BR2_PACKAGE_MPD > > depends on BR2_USE_WCHAR # libglib2, flac > > depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 > > depends on BR2_USE_MMU # libglib2 > > - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6 > > + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14 > > depends on BR2_TOOLCHAIN_HAS_ATOMIC > > select BR2_PACKAGE_BOOST > > select BR2_PACKAGE_LIBGLIB2 > > @@ -315,8 +315,8 @@ config BR2_PACKAGE_MPD_UPNP > > > > endif > > > > -comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.6" > > +comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.9" > > depends on BR2_USE_MMU > > depends on BR2_TOOLCHAIN_HAS_ATOMIC > > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ > > - !BR2_TOOLCHAIN_HAS_THREADS || > > !BR2_TOOLCHAIN_GCC_AT_LEAST_4_6 > > + !BR2_TOOLCHAIN_HAS_THREADS || > > !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 > >
diff --git a/package/mpd/Config.in b/package/mpd/Config.in index 82bbd8d21..e0bb60447 100644 --- a/package/mpd/Config.in +++ b/package/mpd/Config.in @@ -4,7 +4,7 @@ menuconfig BR2_PACKAGE_MPD depends on BR2_USE_WCHAR # libglib2, flac depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 depends on BR2_USE_MMU # libglib2 - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6 + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14 depends on BR2_TOOLCHAIN_HAS_ATOMIC select BR2_PACKAGE_BOOST select BR2_PACKAGE_LIBGLIB2 @@ -315,8 +315,8 @@ config BR2_PACKAGE_MPD_UPNP endif -comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.6" +comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.9" depends on BR2_USE_MMU depends on BR2_TOOLCHAIN_HAS_ATOMIC depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_6 + !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
The version 0.20 of mpd uses C++14 language features and therefor requires at least GCC version 4.9. Fixes: http://autobuild.buildroot.net/results/3fe/3fe440c0b9d05acb44553a8f02f688570e06bca9/ http://autobuild.buildroot.net/results/d33/d3309bea9411fca70d61d07c36f58718bc87e6d1/ http://autobuild.buildroot.net/results/208/208bb987f52b8ba65e3c6fc9b6e917dbd44c0fbd/ http://autobuild.buildroot.net/results/9b9/9b9659ba30afde49912276fe7f9c282953a352ab/ .. and more. Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> --- package/mpd/Config.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)