| Message ID | 1483635305-20423-1-git-send-email-bhumirks@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On 05/01/2017 at 22:25:05 +0530, Bhumika Goyal wrote : > Declare rtc_class_ops structures as const as they are only passed > as an argument to the function devm_rtc_device_register. This argument > is of type const struct rtc_class_ops *, so rtc_class_ops structures > having this property can be declared const. > Done using Coccinelle: > > @r1 disable optional_qualifier @ > identifier i; > position p; > @@ > static struct rtc_class_ops i@p = {...}; > > @ok1@ > identifier r1.i; > position p; > @@ > devm_rtc_device_register(...,&i@p,...) > > @bad@ > position p!={r1.p,ok1.p}; > identifier r1.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > +const > struct rtc_class_ops i; > > File size details: > > text data bss dec hex filename > 559 320 0 879 36f drivers/rtc/rtc-dm355evm.o > 671 192 0 863 35f drivers/rtc/rtc-dm355evm.o > > 4727 320 0 5047 13b7 drivers/rtc/rtc-imxdi.o > 4855 192 0 5047 13b7 drivers/rtc/rtc-imxdi.o > > 1269 192 0 1461 5b5 drivers/rtc/rtc-mxc.o > > File size remains unchanged for : drivers/rtc/rtc-mxc.o > > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> > --- > drivers/rtc/rtc-dm355evm.c | 2 +- > drivers/rtc/rtc-imxdi.c | 2 +- > drivers/rtc/rtc-mxc.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Applied, thanks.
diff --git a/drivers/rtc/rtc-dm355evm.c b/drivers/rtc/rtc-dm355evm.c index 94067f8..f225cd8 100644 --- a/drivers/rtc/rtc-dm355evm.c +++ b/drivers/rtc/rtc-dm355evm.c @@ -116,7 +116,7 @@ static int dm355evm_rtc_set_time(struct device *dev, struct rtc_time *tm) return 0; } -static struct rtc_class_ops dm355evm_rtc_ops = { +static const struct rtc_class_ops dm355evm_rtc_ops = { .read_time = dm355evm_rtc_read_time, .set_time = dm355evm_rtc_set_time, }; diff --git a/drivers/rtc/rtc-imxdi.c b/drivers/rtc/rtc-imxdi.c index 67b56b8..71266ec 100644 --- a/drivers/rtc/rtc-imxdi.c +++ b/drivers/rtc/rtc-imxdi.c @@ -668,7 +668,7 @@ static int dryice_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) return 0; } -static struct rtc_class_ops dryice_rtc_ops = { +static const struct rtc_class_ops dryice_rtc_ops = { .read_time = dryice_rtc_read_time, .set_mmss = dryice_rtc_set_mmss, .alarm_irq_enable = dryice_rtc_alarm_irq_enable, diff --git a/drivers/rtc/rtc-mxc.c b/drivers/rtc/rtc-mxc.c index 359876a..7731912 100644 --- a/drivers/rtc/rtc-mxc.c +++ b/drivers/rtc/rtc-mxc.c @@ -353,7 +353,7 @@ static int mxc_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) } /* RTC layer */ -static struct rtc_class_ops mxc_rtc_ops = { +static const struct rtc_class_ops mxc_rtc_ops = { .release = mxc_rtc_release, .read_time = mxc_rtc_read_time, .set_mmss64 = mxc_rtc_set_mmss,
Declare rtc_class_ops structures as const as they are only passed as an argument to the function devm_rtc_device_register. This argument is of type const struct rtc_class_ops *, so rtc_class_ops structures having this property can be declared const. Done using Coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct rtc_class_ops i@p = {...}; @ok1@ identifier r1.i; position p; @@ devm_rtc_device_register(...,&i@p,...) @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct rtc_class_ops i; File size details: text data bss dec hex filename 559 320 0 879 36f drivers/rtc/rtc-dm355evm.o 671 192 0 863 35f drivers/rtc/rtc-dm355evm.o 4727 320 0 5047 13b7 drivers/rtc/rtc-imxdi.o 4855 192 0 5047 13b7 drivers/rtc/rtc-imxdi.o 1269 192 0 1461 5b5 drivers/rtc/rtc-mxc.o File size remains unchanged for : drivers/rtc/rtc-mxc.o Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> --- drivers/rtc/rtc-dm355evm.c | 2 +- drivers/rtc/rtc-imxdi.c | 2 +- drivers/rtc/rtc-mxc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)