| Message ID | 1483522197-38819-2-git-send-email-preid@electromag.com.au |
|---|---|
| State | Superseded |
| Headers | show |
On 2017-01-04 10:29, Phil Reid wrote: > The spec for the pca954x was missing. This chip is the same as the pca9540 > except that it has interrupt lines. While the i2c_device_id table mapped > the pca9542 to the pca9540 definition the compatible table did not. In > preparation for irq support add the pca9542 definition. A new ACPI table was added behind your back, which needs the same treatment as the i2c table. With that fixed, Acked-by: Peter Rosin <peda@axentia.se> Cheers, peda > Signed-off-by: Phil Reid <preid@electromag.com.au> > --- > drivers/i2c/muxes/i2c-mux-pca954x.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c > index 8bc3d36..981d145 100644 > --- a/drivers/i2c/muxes/i2c-mux-pca954x.c > +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c > @@ -83,6 +83,11 @@ struct pca954x { > .enable = 0x4, > .muxtype = pca954x_ismux, > }, > + [pca_9542] = { > + .nchans = 2, > + .enable = 0x4, > + .muxtype = pca954x_ismux, > + }, > [pca_9543] = { > .nchans = 2, > .muxtype = pca954x_isswi, > @@ -109,7 +114,7 @@ struct pca954x { > > static const struct i2c_device_id pca954x_id[] = { > { "pca9540", pca_9540 }, > - { "pca9542", pca_9540 }, > + { "pca9542", pca_9542 }, > { "pca9543", pca_9543 }, > { "pca9544", pca_9544 }, > { "pca9545", pca_9545 }, > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c index 8bc3d36..981d145 100644 --- a/drivers/i2c/muxes/i2c-mux-pca954x.c +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c @@ -83,6 +83,11 @@ struct pca954x { .enable = 0x4, .muxtype = pca954x_ismux, }, + [pca_9542] = { + .nchans = 2, + .enable = 0x4, + .muxtype = pca954x_ismux, + }, [pca_9543] = { .nchans = 2, .muxtype = pca954x_isswi, @@ -109,7 +114,7 @@ struct pca954x { static const struct i2c_device_id pca954x_id[] = { { "pca9540", pca_9540 }, - { "pca9542", pca_9540 }, + { "pca9542", pca_9542 }, { "pca9543", pca_9543 }, { "pca9544", pca_9544 }, { "pca9545", pca_9545 },
The spec for the pca954x was missing. This chip is the same as the pca9540 except that it has interrupt lines. While the i2c_device_id table mapped the pca9542 to the pca9540 definition the compatible table did not. In preparation for irq support add the pca9542 definition. Signed-off-by: Phil Reid <preid@electromag.com.au> --- drivers/i2c/muxes/i2c-mux-pca954x.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)