| Message ID | 1483522197-38819-3-git-send-email-preid@electromag.com.au |
|---|---|
| State | Superseded |
| Headers | show |
On 2017-01-04 10:29, Phil Reid wrote: > Various muxes can aggregate multiple irq lines and provide a control > register to determine the active line. Add bindings for interrupt > controller support. > I'm no irq expert, but looks good (superficially). With the below nitpick, Acked-by: Peter Rosin <peda@axentia.se> Cheers, peda > Signed-off-by: Phil Reid <preid@electromag.com.au> > --- > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt > index cf53d5f..9f7c275 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt > @@ -19,7 +19,14 @@ Optional Properties: > - i2c-mux-idle-disconnect: Boolean; if defined, forces mux to disconnect all > children in idle state. This is necessary for example, if there are several > multiplexers on the bus and the devices behind them use same I2C addresses. > - > + - interrupt-parent: Phandle for the interrupt controller that services > + interrupts for this device. > + - interrupts: Interrupt mapping for IRQ. > + - interrupt-controller: Marks the device node as a interrupt controller. as an interrupt > + - #interrupt-cells : Should be two. > + - first cell is the pin number > + - second cell is used to specify flags. > + See also Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > > Example: > > @@ -29,6 +36,11 @@ Example: > #size-cells = <0>; > reg = <0x74>; > > + interrupt-parent = <&ipic>; > + interrupts = <17 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; > + #interrupt-cells=<2>; > + > i2c@2 { > #address-cells = <1>; > #size-cells = <0>; > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 04, 2017 at 05:29:54PM +0800, Phil Reid wrote: > Various muxes can aggregate multiple irq lines and provide a control > register to determine the active line. Add bindings for interrupt > controller support. > > Signed-off-by: Phil Reid <preid@electromag.com.au> > --- > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt > index cf53d5f..9f7c275 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt > @@ -19,7 +19,14 @@ Optional Properties: > - i2c-mux-idle-disconnect: Boolean; if defined, forces mux to disconnect all > children in idle state. This is necessary for example, if there are several > multiplexers on the bus and the devices behind them use same I2C addresses. > - > + - interrupt-parent: Phandle for the interrupt controller that services > + interrupts for this device. > + - interrupts: Interrupt mapping for IRQ. > + - interrupt-controller: Marks the device node as a interrupt controller. > + - #interrupt-cells : Should be two. > + - first cell is the pin number > + - second cell is used to specify flags. > + See also Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > > Example: > > @@ -29,6 +36,11 @@ Example: > #size-cells = <0>; > reg = <0x74>; > > + interrupt-parent = <&ipic>; > + interrupts = <17 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; > + #interrupt-cells=<2>; Needs spaces around the '='. With that, Acked-by: Rob Herring <robh@kernel.org> > + > i2c@2 { > #address-cells = <1>; > #size-cells = <0>; > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt index cf53d5f..9f7c275 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt @@ -19,7 +19,14 @@ Optional Properties: - i2c-mux-idle-disconnect: Boolean; if defined, forces mux to disconnect all children in idle state. This is necessary for example, if there are several multiplexers on the bus and the devices behind them use same I2C addresses. - + - interrupt-parent: Phandle for the interrupt controller that services + interrupts for this device. + - interrupts: Interrupt mapping for IRQ. + - interrupt-controller: Marks the device node as a interrupt controller. + - #interrupt-cells : Should be two. + - first cell is the pin number + - second cell is used to specify flags. + See also Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Example: @@ -29,6 +36,11 @@ Example: #size-cells = <0>; reg = <0x74>; + interrupt-parent = <&ipic>; + interrupts = <17 IRQ_TYPE_LEVEL_LOW>; + interrupt-controller; + #interrupt-cells=<2>; + i2c@2 { #address-cells = <1>; #size-cells = <0>;
Various muxes can aggregate multiple irq lines and provide a control register to determine the active line. Add bindings for interrupt controller support. Signed-off-by: Phil Reid <preid@electromag.com.au> --- Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)