| Message ID | 20170104123435.30740-2-jh80.chung@samsung.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed, Jan 04, 2017 at 09:34:31PM +0900, Jaehoon Chung wrote: > Adds the exynos-pcie-phy binding for Exynos PCIe PHY. > This is for using generic PHY framework. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > Changelog on V2: > - Remove the child node. > - Add 2nd address to the parent reg prop. > > Documentation/devicetree/bindings/phy/samsung-phy.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jaehoon, On 01/04/2017 06:04 PM, Jaehoon Chung wrote: > Adds the exynos-pcie-phy binding for Exynos PCIe PHY. > This is for using generic PHY framework. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > Changelog on V2: > - Remove the child node. > - Add 2nd address to the parent reg prop. > > Documentation/devicetree/bindings/phy/samsung-phy.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt > index 9872ba8..ab80bfe 100644 > --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt > +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt > @@ -191,3 +191,20 @@ Example: > usbdrdphy0 = &usb3_phy0; > usbdrdphy1 = &usb3_phy1; > }; > + > +Samsung Exynos SoC series PCIe PHY controller > +-------------------------------------------------- > +Required properties: > +- compatible : Should be set to "samsung,exynos5440-pcie-phy" > +- #phy-cells : Must be zero > +- reg : a register used by phy driver. > + - First is for phy register, second is for block register. > +- reg-names : Must be set to "phy" and "block". > + In general PHY uses a "reference clock" to work, if that is true for 5440 also, will you consider adding an (may be) optional clock properties as well? otherwise this binding looks ok to me. > +Example: > + pcie_phy0: pcie-phy@270000 { > + #phy-cells = <0>; > + compatible = "samsung,exynos5440-pcie-phy"; > + reg = <0x270000 0x1000>, <0x271000 0x40>; > + reg-names = "phy", "block"; > + }; > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Thursday 05 January 2017 09:46 AM, Alim Akhtar wrote: > Hi Jaehoon, > > On 01/04/2017 06:04 PM, Jaehoon Chung wrote: >> Adds the exynos-pcie-phy binding for Exynos PCIe PHY. >> This is for using generic PHY framework. >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> --- >> Changelog on V2: >> - Remove the child node. >> - Add 2nd address to the parent reg prop. >> >> Documentation/devicetree/bindings/phy/samsung-phy.txt | 17 >> +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt >> b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> index 9872ba8..ab80bfe 100644 >> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt >> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt >> @@ -191,3 +191,20 @@ Example: >> usbdrdphy0 = &usb3_phy0; >> usbdrdphy1 = &usb3_phy1; >> }; >> + >> +Samsung Exynos SoC series PCIe PHY controller >> +-------------------------------------------------- >> +Required properties: >> +- compatible : Should be set to "samsung,exynos5440-pcie-phy" >> +- #phy-cells : Must be zero >> +- reg : a register used by phy driver. >> + - First is for phy register, second is for block register. >> +- reg-names : Must be set to "phy" and "block". >> + > In general PHY uses a "reference clock" to work, if that is true for > 5440 also, will you consider adding an (may be) optional clock > properties as well? > Yes, right, second clock, referred as "bus_clk" in pcie node should actually refer to "phy" clock. From Exynos5433 DT patch also you are mapping it to CLK_PCLK_PCIE_PHY which is a phy clk. This is same in Exynos7 as well. So better we have clocks property defined in pcie-phy binding. What do you say? From Exynos5440 UM, PCIe-Phy needs 250 MHz, clock and second clock used as "bus_clk" is providing 250 MHz, so this can be moved in phy driver. Thanks, Pankaj Dubey -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt index 9872ba8..ab80bfe 100644 --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt @@ -191,3 +191,20 @@ Example: usbdrdphy0 = &usb3_phy0; usbdrdphy1 = &usb3_phy1; }; + +Samsung Exynos SoC series PCIe PHY controller +-------------------------------------------------- +Required properties: +- compatible : Should be set to "samsung,exynos5440-pcie-phy" +- #phy-cells : Must be zero +- reg : a register used by phy driver. + - First is for phy register, second is for block register. +- reg-names : Must be set to "phy" and "block". + +Example: + pcie_phy0: pcie-phy@270000 { + #phy-cells = <0>; + compatible = "samsung,exynos5440-pcie-phy"; + reg = <0x270000 0x1000>, <0x271000 0x40>; + reg-names = "phy", "block"; + };
Adds the exynos-pcie-phy binding for Exynos PCIe PHY. This is for using generic PHY framework. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- Changelog on V2: - Remove the child node. - Add 2nd address to the parent reg prop. Documentation/devicetree/bindings/phy/samsung-phy.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)