From patchwork Sat Nov 13 18:26:26 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 71066 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ww0-f56.google.com (mail-ww0-f56.google.com [74.125.82.56]) by ozlabs.org (Postfix) with ESMTP id 603B1B7118 for ; Sun, 14 Nov 2010 05:26:45 +1100 (EST) Received: by wwj40 with SMTP id 40sf2987691wwj.11 for ; Sat, 13 Nov 2010 10:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:received:received:date:from:to:cc :subject:message-id:mime-version:user-agent:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-disposition; bh=woy2b7EUVI6i2XdGnz3XcHJfgKitAqg1YEiEf5/2Lbw=; b=VoEm2ab9bXjKLCZx9GoYH/JPS5UnnMYUGvWGUosWV2S3Kgd1mVGgys/BTet+tvoqru /7tjET0RDqFX7cMCXvA/+SBMB5RObE3bsGQXtfmdDVT0L4nX4FIQqwSi5BHdZQH5HFdU VqXENPpjNCfZRpSHOwHX7+slBwRfJ5pOMJG6E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:date:from:to:cc:subject:message-id :mime-version:user-agent:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-disposition; b=JkdyRh58Kl+9JLTV2Ki/HvYDDUGl1z9JzRhtiWfx9glt2RN1rVYjtC1+Ge/csB6epT 1eskdNBuXaYFVBCapOKfb9N0VFuNmWfscYVH2rYaFRBnrG8qcxaQ0+/NknZYdl2zqkpr PK87KhTJPcTPF1DHrfwZlUZ2BQ4xXIBIrcb2A= Received: by 10.216.179.145 with SMTP id h17mr202266wem.21.1289672801734; Sat, 13 Nov 2010 10:26:41 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.227.3.11 with SMTP id 11ls1526424wbl.3.p; Sat, 13 Nov 2010 10:26:40 -0800 (PST) Received: by 10.227.145.77 with SMTP id c13mr169279wbv.24.1289672800375; Sat, 13 Nov 2010 10:26:40 -0800 (PST) Received: by 10.227.145.77 with SMTP id c13mr169278wbv.24.1289672800356; Sat, 13 Nov 2010 10:26:40 -0800 (PST) Received: from mail-wy0-f175.google.com (mail-wy0-f175.google.com [74.125.82.175]) by gmr-mx.google.com with ESMTP id q27si1462736wbv.5.2010.11.13.10.26.39; Sat, 13 Nov 2010 10:26:39 -0800 (PST) Received-SPF: pass (google.com: domain of error27@gmail.com designates 74.125.82.175 as permitted sender) client-ip=74.125.82.175; Received: by wyi11 with SMTP id 11so3621510wyi.20 for ; Sat, 13 Nov 2010 10:26:39 -0800 (PST) Received: by 10.227.133.11 with SMTP id d11mr4003712wbt.173.1289672798955; Sat, 13 Nov 2010 10:26:38 -0800 (PST) Received: from bicker (h2dc2.n1.ips.mtn.co.ug [41.210.173.194]) by mx.google.com with ESMTPS id i19sm3771847wbe.17.2010.11.13.10.26.34 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 13 Nov 2010 10:26:38 -0800 (PST) Date: Sat, 13 Nov 2010 21:26:26 +0300 From: Dan Carpenter To: Alessandro Zummo , Lars-Peter Clausen Cc: rtc-linux@googlegroups.com, kernel-janitors@vger.kernel.org Subject: [rtc-linux] [patch] rtc: jz4740: signedness bug Message-ID: <20101113182626.GC1795@bicker> MIME-Version: 1.0 User-Agent: Mutt/1.5.20 (2009-06-14) X-Original-Sender: error27@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of error27@gmail.com designates 74.125.82.175 as permitted sender) smtp.mail=error27@gmail.com; dkim=pass (test mode) header.i=@gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-Disposition: inline platform_get_irq() can return negatives so the rtc->irq should be signed to handle it. Signed-off-by: Dan Carpenter Acked-By: Lars-Peter Clausen diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c index 2e16f72..cfcd2da 100644 --- a/drivers/rtc/rtc-jz4740.c +++ b/drivers/rtc/rtc-jz4740.c @@ -42,7 +42,7 @@ struct jz4740_rtc { struct rtc_device *rtc; - unsigned int irq; + int irq; spinlock_t lock; };