| Message ID | 20170103170119.35950-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Jan 03, 2017 at 07:01:17PM +0200, Andy Shevchenko wrote: > The macro for_each_set_bit() effectively looks up to the next set bit in array > of bits. > > Instead of open coding that switch to for_each_set_bit() in > gpio_chip_set_multiple(). > > While here, make gpio_chip_set_multiple() non-destructive against its > parameters. We are safe since all callers, i.e. > gpiod_set_array_value_complex(), handle that already. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 3, 2017 at 6:01 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > The macro for_each_set_bit() effectively looks up to the next set bit in array > of bits. > > Instead of open coding that switch to for_each_set_bit() in > gpio_chip_set_multiple(). > > While here, make gpio_chip_set_multiple() non-destructive against its > parameters. We are safe since all callers, i.e. > gpiod_set_array_value_complex(), handle that already. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Irrestible clarification patch, applied with Mika's review tag. Thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index f4c26c7826cd..7f51c9bf5533 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1,3 +1,4 @@ +#include <linux/bitops.h> #include <linux/kernel.h> #include <linux/module.h> #include <linux/interrupt.h> @@ -2570,18 +2571,11 @@ static void gpio_chip_set_multiple(struct gpio_chip *chip, if (chip->set_multiple) { chip->set_multiple(chip, mask, bits); } else { - int i; - for (i = 0; i < chip->ngpio; i++) { - if (mask[BIT_WORD(i)] == 0) { - /* no more set bits in this mask word; - * skip ahead to the next word */ - i = (BIT_WORD(i) + 1) * BITS_PER_LONG - 1; - continue; - } - /* set outputs if the corresponding mask bit is set */ - if (__test_and_clear_bit(i, mask)) - chip->set(chip, i, test_bit(i, bits)); - } + unsigned int i; + + /* set outputs if the corresponding mask bit is set */ + for_each_set_bit(i, mask, chip->ngpio) + chip->set(chip, i, test_bit(i, bits)); } }
The macro for_each_set_bit() effectively looks up to the next set bit in array of bits. Instead of open coding that switch to for_each_set_bit() in gpio_chip_set_multiple(). While here, make gpio_chip_set_multiple() non-destructive against its parameters. We are safe since all callers, i.e. gpiod_set_array_value_complex(), handle that already. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpiolib.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-)