| Message ID | 1483456720-9929-1-git-send-email-volodymyr.bendiuga@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Volodymyr Bendiuga <volodymyr.bendiuga@gmail.com> Date: Tue, 3 Jan 2017 16:18:40 +0100 > + MV88E6XXX_FLAG_G2_INT | \ Space before TAB character is still there on this line, right after the "+".
On Tue, Jan 03, 2017 at 04:18:40PM +0100, Volodymyr Bendiuga wrote: > From: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se> > > This chip needs MV88E6XXX_FLAG_G2_INT > > Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > --- > drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > index af54bae..431e954 100644 > --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h > @@ -566,6 +566,7 @@ enum mv88e6xxx_cap { > (MV88E6XXX_FLAG_G1_ATU_FID | \ > MV88E6XXX_FLAG_G1_VTU_FID | \ > MV88E6XXX_FLAG_GLOBAL2 | \ > + MV88E6XXX_FLAG_G2_INT | \ checkpatch is your friend: $ ./scripts/checkpatch.pl volodymyr.bendiuga ERROR: code indent should use tabs where possible #76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569: + ^I MV88E6XXX_FLAG_G2_INT |^I\$ WARNING: please, no space before tabs #76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569: + ^I MV88E6XXX_FLAG_G2_INT |^I\$ WARNING: please, no spaces at the start of a line #76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569: + ^I MV88E6XXX_FLAG_G2_INT |^I\$ total: 1 errors, 2 warnings, 0 checks, 7 lines checked Andrew
diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h index af54bae..431e954 100644 --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h @@ -566,6 +566,7 @@ enum mv88e6xxx_cap { (MV88E6XXX_FLAG_G1_ATU_FID | \ MV88E6XXX_FLAG_G1_VTU_FID | \ MV88E6XXX_FLAG_GLOBAL2 | \ + MV88E6XXX_FLAG_G2_INT | \ MV88E6XXX_FLAG_G2_MGMT_EN_2X | \ MV88E6XXX_FLAG_G2_MGMT_EN_0X | \ MV88E6XXX_FLAG_G2_POT | \