Patchwork [gccgo] trivial typo

login
register
mail settings
Submitter Ralf Wildenhues
Date Nov. 13, 2010, 6:27 a.m.
Message ID <20101113062713.GB22036@gmx.de>
Download mbox | patch
Permalink /patch/71038/
State New
Headers show

Comments

Ralf Wildenhues - Nov. 13, 2010, 6:27 a.m.
I'm not sure how the policy is for obvious changes to branches,
so, OK to fix this quoting error to avoid the following issue?

config.status: executing default-1 commands
../../gccgo/zlib/../config-ml.in: line 858: unexpected EOF while looking for matching `''
../../gccgo/zlib/../config-ml.in: line 891: syntax error: unexpected end of file
../../gccgo/zlib/../config-ml.in: line 891: warning: syntax errors in . or eval will cause future versions of the shell to abort as Posix requires

By the way, config-ml.in should be synced with Automake, so at the point
when the gccgo branch is merged to trunk it would be good to have a
patch for automake/lib/config-ml.in.  I can take care of this if you
prefer.

Thanks,
Ralf

2010-11-13  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	* config-ml.in: Fix quoting.
Ian Taylor - Nov. 15, 2010, 5:28 p.m.
Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:

> I'm not sure how the policy is for obvious changes to branches,
> so, OK to fix this quoting error to avoid the following issue?
>
> config.status: executing default-1 commands
> ../../gccgo/zlib/../config-ml.in: line 858: unexpected EOF while looking for matching `''
> ../../gccgo/zlib/../config-ml.in: line 891: syntax error: unexpected end of file
> ../../gccgo/zlib/../config-ml.in: line 891: warning: syntax errors in . or eval will cause future versions of the shell to abort as Posix requires

Thanks, I have this patch in my copy of the branch but I forgot to
commit it.  I went ahead and committed it now.

> By the way, config-ml.in should be synced with Automake, so at the point
> when the gccgo branch is merged to trunk it would be good to have a
> patch for automake/lib/config-ml.in.  I can take care of this if you
> prefer.

I hadn't realized that config-ml.in was also in automake.  If you are
able to care of merging the GOC patch over, that would be great.
Otherwise I can do it easily enough.

Ian

Patch

diff --git a/config-ml.in b/config-ml.in
index 3ebc5e1..55ff407 100644
--- a/config-ml.in
+++ b/config-ml.in
@@ -759,7 +759,7 @@  if [ -n "${multidirs}" ] && [ -z "${ml_norecursion}" ]; then
 	F77_=$F77' '
 	GCJ_=$GCJ' '
 	GFORTRAN_=$GFORTRAN' '
-	GOC_=$GOC '
+	GOC_=$GOC' '
     else
 	# Create a regular expression that matches any string as long
 	# as ML_POPDIR.