Message ID | 20101113011810.GA21395@gmx.de |
---|---|
State | New |
Headers | show |
Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes: > * Ian Lance Taylor wrote on Fri, Nov 12, 2010 at 10:51:33PM CET: >> This is a ping for the patch which adds the -fdump-go-spec option. For >> clarity, I have included the complete patch here. I originally proposed >> this patch, under the name -ggo, here: >> >> http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00369.html > >> * Does anybody have any objections to this patch? > > The gccgo branch has at least one regression introduced AFAICS by the > GOC patch, that is shared by this patch, and fixed with the one-liner > below. Thanks for trying it. I have as it happens already fixed that in my own copy of godump.c, and the fix will be included in the commit. Ian
diff --git a/gcc/godump.c b/gcc/godump.c index 0836e3c..f9cfffc 100644 --- a/gcc/godump.c +++ b/gcc/godump.c @@ -495,6 +495,7 @@ go_format_type (struct godump_container *container, tree type, obstack_grow (ob, "_f", 2); snprintf (buf, sizeof buf, "%d", i); obstack_grow (ob, buf, strlen (buf)); + obstack_grow (ob, " ", 1); i++; } else