diff mbox

Correct MIPS math-tests.h condition for sNaN payload preservation [committed]

Message ID alpine.DEB.2.20.1701022029000.24470@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers Jan. 2, 2017, 8:29 p.m. UTC 
Testing for MIPS soft float shows that the issue with NaN payload
preservation applies to soft float as well as hard float: the
sfp-machine.h emulates hardware non-preservation semantics, although
only for the case of two NaN arguments.

This patch duly changes the MIPS math-tests.h to expect such
non-preservation for soft float as well as hard float.  The issue in
the NAN2008 case for which I posted
<https://gcc.gnu.org/ml/gcc-patches/2017-01/msg00034.html>, of sNaN
payloads being preserved but qNaN payloads not being preserved, is not
currently an issue for glibc tests because we don't have any tests
that check for qNaN payloads being preserved by arithmetic, so a
simple __mips_nan2008 conditional suffices without needing compiler
version checks in the __mips_nan2008 case.

Tested for mips64 soft float.  Committed.

2017-01-02  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/mips/math-tests.h (SNAN_TESTS_PRESERVE_PAYLOAD): Do not
	condition on [__mips_hard_float].
diff mbox

Patch

diff --git a/sysdeps/mips/math-tests.h b/sysdeps/mips/math-tests.h
index caa2b4f..7680db2 100644
--- a/sysdeps/mips/math-tests.h
+++ b/sysdeps/mips/math-tests.h
@@ -37,7 +37,7 @@ 
 
 /* NaN payload preservation when converting a signaling NaN to quiet
    is only required in NAN2008 mode.  */
-#if defined __mips_hard_float && !defined __mips_nan2008
+#ifndef __mips_nan2008
 # define SNAN_TESTS_PRESERVE_PAYLOAD	0
 #endif